Issue 424423004: Push pending tag and synthesized commit in a single git push operation.

Issue 424423004: Push pending tag and synthesized commit in a single git push operation. (Closed)

Created:
6 years, 4 months ago by Vadim Sh.

Modified:
6 years, 4 months ago

Reviewers:
iannucci

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/infra/infra.git@master

Project:
infra

Visibility:
Public.

More Reviews

Description

Push pending tag and synthesized commit in a single git push operation. R=iannucci@chromium.org BUG= Committed: https://chromium.googlesource.com/infra/infra/+/9059a6d103f9c71e391ef74fa5c4b08b71c582f6

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -46 lines)			Patch
M	infra/libs/git2/ref.py	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	infra/libs/git2/repo.py	View	1	2 chunks	+21 lines, -1 line	0 comments	Download
M	infra/libs/git2/test/ref_test.py	View		1 chunk	+2 lines, -17 lines	0 comments	Download
M	infra/libs/git2/test/repo_test.py	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	infra/services/gnumbd/gnumbd.py	View		2 chunks	+10 lines, -7 lines	0 comments	Download
M	infra/services/gnumbd/test/gnumbd_test.expected/branch.yaml	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	infra/services/gnumbd/test/gnumbd_test.expected/branch_from_branch.yaml	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	infra/services/gnumbd/test/gnumbd_test.expected/enforce_commit_timestamps.yaml	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	infra/services/gnumbd/test/gnumbd_test.expected/extra_user_footer.yaml	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	infra/services/gnumbd/test/gnumbd_test.expected/extra_user_footer_bad.yaml	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	infra/services/gnumbd/test/gnumbd_test.expected/incoming_svn_id_drops.yaml	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	infra/services/gnumbd/test/gnumbd_test.expected/manual_merge_commits_ok.yaml	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	infra/services/gnumbd/test/gnumbd_test.expected/multi_pending.yaml	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	infra/services/gnumbd/test/gnumbd_test.expected/normal_update.yaml	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	infra/services/gnumbd/test/gnumbd_test.expected/normal_with_master_lag.yaml	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	infra/services/gnumbd/test/gnumbd_test.expected/tag_lagging.yaml	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

iannucci

lgtm https://codereview.chromium.org/424423004/diff/1/infra/libs/git2/repo.py File infra/libs/git2/repo.py (right): https://codereview.chromium.org/424423004/diff/1/infra/libs/git2/repo.py#newcode154 infra/libs/git2/repo.py:154: """Push commits to refs on the remote, and ...

6 years, 4 months ago (2014-07-30 19:28:18 UTC) #2

Vadim Sh.

https://codereview.chromium.org/424423004/diff/1/infra/libs/git2/repo.py File infra/libs/git2/repo.py (right): https://codereview.chromium.org/424423004/diff/1/infra/libs/git2/repo.py#newcode154 infra/libs/git2/repo.py:154: """Push commits to refs on the remote, and also ...

6 years, 4 months ago (2014-07-30 20:15:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimsh@chromium.org/424423004/20001

6 years, 4 months ago (2014-07-30 20:19:14 UTC) #6

commit-bot: I haz the power

6 years, 4 months ago (2014-07-30 20:19:50 UTC) #7

Message was sent while issue was closed.

Change committed as 9059a6d103f9c71e391ef74fa5c4b08b71c582f6

Expand Messages | Collapse Messages