Make Chrome default browser an opt-out instead of an opt-in on first run.

chrome/browser/views/first_run_customize_view.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/first_run_customize_view.h"
 
 #include "chrome/app/locales/locale_settings.h"
 #include "chrome/app/theme/theme_resources.h"
 #include "chrome/browser/importer/importer.h"
 #include "chrome/browser/first_run.h"
-#include "chrome/browser/shell_integration.h"
 #include "chrome/browser/user_metrics.h"
 #include "chrome/browser/views/standard_layout.h"
 #include "chrome/common/l10n_util.h"
 #include "chrome/common/resource_bundle.h"
 #include "chrome/views/checkbox.h"
 #include "chrome/views/combo_box.h"
 #include "chrome/views/image_view.h"
 #include "chrome/views/label.h"
 #include "chrome/views/throbber.h"
 #include "chrome/views/window.h"
 
 #include "chromium_strings.h"
 #include "generated_resources.h"
 
 FirstRunCustomizeView::FirstRunCustomizeView(Profile* profile,
                                              ImporterHost* importer_host,
-                                             CustomizeViewObserver* observer)
+                                             CustomizeViewObserver* observer,
+                                             bool default_browser_checked)
     : FirstRunViewBase(profile),
       main_label_(NULL),
       import_cbox_(NULL),
-      default_browser_cbox_(NULL),
       import_from_combo_(NULL),
       shortcuts_label_(NULL),
       desktop_shortcut_cbox_(NULL),
       quick_shortcut_cbox_(NULL),
       customize_observer_(observer) {
   importer_host_ = importer_host;
   DCHECK(importer_host_);
   SetupControls();
+
+  // The checkbox for Default Browser should be the same for FirstRun and
+  // the customize view, so that the user selection isn't lost when you uncheck
+  // and then open the Customize dialog. Therefore, we propagate the selection
+  // status of the default browser here.
+  default_browser_->SetIsSelected(default_browser_checked);
 }
 
 FirstRunCustomizeView::~FirstRunCustomizeView() {
 }
 
 ChromeViews::CheckBox* FirstRunCustomizeView::MakeCheckBox(int label_id) {
   ChromeViews::CheckBox* cbox =
       new ChromeViews::CheckBox(l10n_util::GetString(label_id));
   cbox->SetListener(this);
   AddChildView(cbox);
   return cbox;
 }
 
 void FirstRunCustomizeView::SetupControls() {
   using ChromeViews::Label;
   using ChromeViews::CheckBox;
 
   main_label_ = new Label(l10n_util::GetString(IDS_FR_CUSTOMIZE_DLG_TEXT));
   main_label_->SetMultiLine(true);
   main_label_->SetHorizontalAlignment(Label::ALIGN_LEFT);
   AddChildView(main_label_);
 
   import_cbox_ = MakeCheckBox(IDS_FR_CUSTOMIZE_IMPORT);
 
   import_from_combo_ = new ChromeViews::ComboBox(this);
   AddChildView(import_from_combo_);
 
-  default_browser_cbox_ = MakeCheckBox(IDS_FR_CUSTOMIZE_DEFAULT_BROWSER);
-
   shortcuts_label_ =
       new Label(l10n_util::GetString(IDS_FR_CUSTOMIZE_SHORTCUTS));
   shortcuts_label_->SetHorizontalAlignment(Label::ALIGN_LEFT);
   AddChildView(shortcuts_label_);
 
   // The two check boxes for the different shortcut creation.
   desktop_shortcut_cbox_ = MakeCheckBox(IDS_FR_CUSTOM_SHORTCUT_DESKTOP);
   desktop_shortcut_cbox_->SetIsSelected(true);
 
   quick_shortcut_cbox_ = MakeCheckBox(IDS_FR_CUSTOM_SHORTCUT_QUICKL);
@@ skipping 30 matching lines @@
   import_cbox_->GetPreferredSize(&pref_size);
   import_cbox_->SetBounds(kPanelHorizMargin, next_v_space,
                                pref_size.cx, pref_size.cy);
 
   import_cbox_->SetIsSelected(true);
 
   int x_offset = import_cbox_->x() +
                  import_cbox_->width();
 
   import_from_combo_->GetPreferredSize(&pref_size);
-  import_from_combo_->SetBounds(x_offset, next_v_space,
-                                pref_size.cx + kComboExtraPad, pref_size.cy);
+  import_from_combo_->SetBounds(x_offset,
+                                next_v_space +
+                                    (import_cbox_->height() -
+                                     pref_size.cy) / 2,
+                                pref_size.cx + kComboExtraPad,
+                                pref_size.cy);
 
   AdjustDialogWidth(import_from_combo_);
 
   next_v_space = import_cbox_->y() + import_cbox_->height() +
                  kUnrelatedControlVerticalSpacing;
 
-  default_browser_cbox_->GetPreferredSize(&pref_size);
-  default_browser_cbox_->SetBounds(kPanelHorizMargin, next_v_space,
-                                   pref_size.cx, pref_size.cy);
-
-  AdjustDialogWidth(default_browser_cbox_);
-
-  next_v_space += default_browser_cbox_->height() +
-                  kUnrelatedControlVerticalSpacing;
-
   shortcuts_label_->GetPreferredSize(&pref_size);
   shortcuts_label_->SetBounds(kPanelHorizMargin, next_v_space,
                               pref_size.cx, pref_size.cy);
 
   AdjustDialogWidth(shortcuts_label_);
 
   next_v_space += shortcuts_label_->height() +
                   kRelatedControlVerticalSpacing;
 
   desktop_shortcut_cbox_->GetPreferredSize(&pref_size);
@@ skipping 36 matching lines @@
   return this;
 }
 
 bool FirstRunCustomizeView::Accept() {
   if (!IsDialogButtonEnabled(DIALOGBUTTON_OK))
     return false;
 
   DisableButtons();
   import_cbox_->SetEnabled(false);
   import_from_combo_->SetEnabled(false);
-  default_browser_cbox_->SetEnabled(false);
   desktop_shortcut_cbox_->SetEnabled(false);
   quick_shortcut_cbox_->SetEnabled(false);
 
   if (desktop_shortcut_cbox_->IsSelected()) {
     UserMetrics::RecordAction(L"FirstRunCustom_Do_DesktopShortcut", profile_);
     CreateDesktopShortcut();
   }
   if (quick_shortcut_cbox_->IsSelected()) {
     UserMetrics::RecordAction(L"FirstRunCustom_Do_QuickLShortcut", profile_);
     CreateQuickLaunchShortcut();
   }
   if (!import_cbox_->IsSelected()) {
     UserMetrics::RecordAction(L"FirstRunCustom_No_Import", profile_);
   } else {
     int browser_selected = import_from_combo_->GetSelectedItem();
     FirstRun::ImportSettings(profile_, browser_selected,
                              GetDefaultImportItems(), window()->GetHWND());
   }
-  if (default_browser_cbox_->IsSelected()) {
-    UserMetrics::RecordAction(L"FirstRunCustom_Do_DefBrowser", profile_);
-    ShellIntegration::SetAsDefaultBrowser();
-  }
+  if (default_browser_->IsSelected())
+    SetDefaultBrowser();
 
   if (customize_observer_)
     customize_observer_->CustomizeAccepted();
 
   // Exit the message loop we were started with so that startup can continue.
   MessageLoop::current()->Quit();
 
   return true;
 }
 
 bool FirstRunCustomizeView::Cancel() {
   if (customize_observer_)
     customize_observer_->CustomizeCanceled();
 
   // Don't quit the message loop in this case - we're still showing the main
   // First run dialog box underneath ourselves.
 
   return true;
 }