Issue 424383002: Experiment with displaying origins in the Omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 424383002: Experiment with displaying origins in the Omnibox. (Closed)

Created:
6 years, 4 months ago by palmer

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews, tfarina, felt

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Experiment with displaying origins in the Omnibox. 3 states: Good (green), Dubious (yellow + Caution Triangle), Bad (red + Danger X). Extended Validation is a special case of Good: green, + EV certificate holder name. BUG=

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+116 lines, -0 lines)			Patch
M	chrome/browser/ui/toolbar/toolbar_model.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/toolbar/toolbar_model_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/toolbar/toolbar_model_impl.cc	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.h	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View	5 chunks	+68 lines, -0 lines	0 comments	Download