Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 424363004: Update third_party/webdriver/pylib to r18456 and delete test_data (Closed)

Created:
6 years, 4 months ago by samuong
Modified:
6 years, 4 months ago
Reviewers:
stgao
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update third_party/webdriver/pylib to r18456 and delete test_data BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287205

Patch Set 1 #

Total comments: 2

Patch Set 2 : "python" -> "pylib" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15159 lines) Patch
M DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/webdriver/LICENSE View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/webdriver/README.chromium View 1 2 chunks +2 lines, -7 lines 0 comments Download
D third_party/webdriver/test_data/Bin/Intelligencia.UrlRewriter.dll View Binary file 0 comments Download
D third_party/webdriver/test_data/ClickTest_testClicksASurroundingStrongTag.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/webdriver/test_data/Page.aspx View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/webdriver/test_data/Page.aspx.cs View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/webdriver/test_data/Redirect.aspx View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/webdriver/test_data/Redirect.aspx.cs View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/webdriver/test_data/Settings.StyleCop View 1 chunk +0 lines, -759 lines 0 comments Download
D third_party/webdriver/test_data/Web.Config View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/webdriver/test_data/actualXhtmlPage.xhtml View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/webdriver/test_data/ajaxy_page.html View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/webdriver/test_data/alerts.html View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/webdriver/test_data/animals/.gitignore View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/webdriver/test_data/banner.gif View Binary file 0 comments Download
D third_party/webdriver/test_data/blank.html View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/webdriver/test_data/bodyTypingTest.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/webdriver/test_data/booleanAttributes.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/webdriver/test_data/child/childPage.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/webdriver/test_data/child/grandchild/grandchildPage.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/webdriver/test_data/clickEventPage.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/webdriver/test_data/click_frames.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/webdriver/test_data/click_jacker.html View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/webdriver/test_data/click_out_of_bounds.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/webdriver/test_data/click_out_of_bounds_overflow.html View 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/webdriver/test_data/click_source.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/webdriver/test_data/clicks.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/webdriver/test_data/closeable_window.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/webdriver/test_data/cn-test.html View 1 1 chunk +0 lines, -156 lines 0 comments Download
D third_party/webdriver/test_data/cookies.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-bg_diagonals-thick_18_b81900_40x40.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-bg_diagonals-thick_20_666666_40x40.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-bg_flat_10_000000_40x100.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-bg_glass_100_f6f6f6_1x400.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-bg_glass_100_fdf5ce_1x400.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-bg_glass_65_ffffff_1x400.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-bg_gloss-wave_35_f6a828_500x100.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-bg_highlight-soft_100_eeeeee_1x100.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-bg_highlight-soft_75_ffe45c_1x100.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-icons_222222_256x240.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-icons_228ef1_256x240.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-icons_ef8c08_256x240.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-icons_ffd27a_256x240.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/images/ui-icons_ffffff_256x240.png View Binary file 0 comments Download
D third_party/webdriver/test_data/css/ui-lightness/jquery-ui-1.8.10.custom.css View 1 chunk +0 lines, -573 lines 0 comments Download
D third_party/webdriver/test_data/deletingFrame.htm View 1 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/webdriver/test_data/document_write_in_onload.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/webdriver/test_data/dragAndDropTest.html View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/webdriver/test_data/draggableLists.html View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/webdriver/test_data/droppableItems.html View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/webdriver/test_data/dynamic.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/webdriver/test_data/dynamicallyModifiedPage.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/webdriver/test_data/errors.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/webdriver/test_data/formPage.html View 1 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/webdriver/test_data/formSelectionPage.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/webdriver/test_data/frameset.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/webdriver/test_data/framesetPage2.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/webdriver/test_data/galaxy/.gitignore View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/webdriver/test_data/globalscope.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/webdriver/test_data/html5/blue.jpg View Binary file 0 comments Download
D third_party/webdriver/test_data/html5/database.js View 1 chunk +0 lines, -84 lines 0 comments Download
D third_party/webdriver/test_data/html5/geolocation.js View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/webdriver/test_data/html5/green.jpg View Binary file 0 comments Download
D third_party/webdriver/test_data/html5/offline.html View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/webdriver/test_data/html5/red.jpg View Binary file 0 comments Download
D third_party/webdriver/test_data/html5/status.html View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/webdriver/test_data/html5/test.appcache View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/webdriver/test_data/html5/yellow.jpg View Binary file 0 comments Download
D third_party/webdriver/test_data/html5Page.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/webdriver/test_data/icon.gif View Binary file 0 comments Download
D third_party/webdriver/test_data/iframeWithAlert.html View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/webdriver/test_data/iframeWithIframe.html View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/webdriver/test_data/iframes.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/webdriver/test_data/javascriptEnhancedForm.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/webdriver/test_data/javascriptPage.html View 1 chunk +0 lines, -270 lines 0 comments Download
D third_party/webdriver/test_data/jquery-1.3.2.js View 1 chunk +0 lines, -4376 lines 0 comments Download
D third_party/webdriver/test_data/js/jquery-1.4.4.min.js View 1 chunk +0 lines, -167 lines 0 comments Download
D third_party/webdriver/test_data/js/jquery-ui-1.8.10.custom.min.js View 1 chunk +0 lines, -782 lines 0 comments Download
D third_party/webdriver/test_data/linked_image.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/webdriver/test_data/longContentPage.html View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/webdriver/test_data/macbeth.html View 1 chunk +0 lines, -5255 lines 0 comments Download
D third_party/webdriver/test_data/map.png View Binary file 0 comments Download
D third_party/webdriver/test_data/map_visibility.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/webdriver/test_data/markerTransparent.png View Binary file 0 comments Download
D third_party/webdriver/test_data/meta-redirect.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/webdriver/test_data/missedJsReference.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/webdriver/test_data/mousePositionTracker.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/webdriver/test_data/nestedElements.html View 1 chunk +0 lines, -155 lines 0 comments Download
D third_party/webdriver/test_data/pageWithOnLoad.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/webdriver/test_data/pageWithOnUnload.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/webdriver/test_data/plain.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/webdriver/test_data/readOnlyPage.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/webdriver/test_data/rectangles.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/webdriver/test_data/resultPage.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/webdriver/test_data/rich_text.html View 1 chunk +0 lines, -160 lines 0 comments Download
D third_party/webdriver/test_data/scroll.html View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/webdriver/test_data/scroll2.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/webdriver/test_data/scroll3.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/webdriver/test_data/scroll4.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/webdriver/test_data/scroll5.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/webdriver/test_data/selectPage.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/webdriver/test_data/selectableItems.html View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/webdriver/test_data/sessionCookie.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/webdriver/test_data/sessionCookieDest.html View 1 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/webdriver/test_data/simple.xml View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/webdriver/test_data/simpleTest.html View 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/webdriver/test_data/slowLoadingAlert.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/webdriver/test_data/slowLoadingResourcePage.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/webdriver/test_data/slow_loading_iframes.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/webdriver/test_data/styledPage.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/webdriver/test_data/svgPiechart.xhtml View 1 chunk +0 lines, -84 lines 0 comments Download
D third_party/webdriver/test_data/tables.html View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/webdriver/test_data/transformable.xml View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/webdriver/test_data/transformable.xsl View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/webdriver/test_data/underscore.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/webdriver/test_data/upload.html View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/webdriver/test_data/veryLargeCanvas.html View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/webdriver/test_data/visibility-css.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/webdriver/test_data/win32frameset.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/webdriver/test_data/xhtmlFormPage.xhtml View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/webdriver/test_data/xhtmlTest.html View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
samuong
ptal
6 years, 4 months ago (2014-08-02 01:24:11 UTC) #1
stgao
lgtm with a nit. https://codereview.chromium.org/424363004/diff/1/third_party/webdriver/README.chromium File third_party/webdriver/README.chromium (right): https://codereview.chromium.org/424363004/diff/1/third_party/webdriver/README.chromium#newcode14 third_party/webdriver/README.chromium:14: python/ pylib?
6 years, 4 months ago (2014-08-02 01:34:51 UTC) #2
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 4 months ago (2014-08-02 05:16:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/424363004/20001
6 years, 4 months ago (2014-08-02 05:17:54 UTC) #4
samuong
https://codereview.chromium.org/424363004/diff/1/third_party/webdriver/README.chromium File third_party/webdriver/README.chromium (right): https://codereview.chromium.org/424363004/diff/1/third_party/webdriver/README.chromium#newcode14 third_party/webdriver/README.chromium:14: python/ On 2014/08/02 01:34:50, Shuotao wrote: > pylib? Done.
6 years, 4 months ago (2014-08-02 05:19:03 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 11:45:22 UTC) #6
Message was sent while issue was closed. 
Change committed as 287205

Powered by Google App Engine
This is Rietveld 408576698