Issue 42435: Implement default css for toolstrips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42435: Implement default css for toolstrips. (Closed)

Created:
11 years, 9 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Implement default css for toolstrips.

Patch Set 1 #

Patch Set 2 : Fix crash #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+293 lines, -226 lines)			Patch
M	chrome/browser/browser_resources.grd	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_view.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_view.cc	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/extensions.html	View		1 chunk	+0 lines, -224 lines	0 comments	Download
A	chrome/browser/resources/extensions_toolstrip.css	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/extensions_ui.html	View		1 chunk	+224 lines, -0 lines	1 comment	Download
M	chrome/common/render_messages_internal.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

Ok, I worked around the assert and fixed up some details.

11 years, 9 months ago (2009-03-21 05:34:01 UTC) #1

Matt Perry

11 years, 9 months ago (2009-03-23 18:43:56 UTC) #2

lgtm

http://codereview.chromium.org/42435/diff/1013/22
File chrome/browser/resources/extensions_ui.html (right):

http://codereview.chromium.org/42435/diff/1013/22#newcode1
Line 1: <!DOCTYPE HTML>
Could you "svn mv" the original file to this to preserve the svn history?

Expand Messages | Collapse Messages