Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 424273003: Add a usecounter for SMIL elements in the document (Closed)

Created:
6 years, 4 months ago by pdr.
Modified:
6 years, 4 months ago
Reviewers:
fs, kouhei (in TOK), eseidel
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr., Eric Willigers
Project:
blink
Visibility:
Public.

Description

Add a usecounter for SMIL elements in the document The current SVGAnimation usecounter [1] is skewed by Modernizr [2] and doesn't count the other animation types such as <animateMotion>. This patch adds a new usecounter for SMIL animation elements that are in the document. I manually confirmed this does not fire on the Modernizr test page [3] whereas the old SVGAnimation counter does. [1] http://www.chromestatus.com/metrics/feature/timeline/popularity/90 [2] https://github.com/Modernizr/Modernizr/blob/v2.8.3/modernizr.js#L832-L835 [3] http://modernizr.github.io/Modernizr/test/ BUG=258298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pdr.
6 years, 4 months ago (2014-07-30 00:52:13 UTC) #1
kouhei (in TOK)
lgtm
6 years, 4 months ago (2014-07-30 01:05:24 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 4 months ago (2014-07-30 01:05:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/424273003/1
6 years, 4 months ago (2014-07-30 01:07:08 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-07-30 01:59:37 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 02:46:09 UTC) #6
Message was sent while issue was closed.
Change committed as 179191

Powered by Google App Engine
This is Rietveld 408576698