Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 424263005: teach rebaseline_server to generate diffs of rendered SKPs (Closed)

Created:
6 years, 4 months ago by epoger
Modified:
6 years, 4 months ago
Reviewers:
rmistry
CC:
reviews_skia.org, stephana
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

teach rebaseline_server to generate diffs of rendered SKPs Creates a new live-view.html page, served by the rebaseline_server, that will display diffs between two sets of rendered SKP images. BUG=skia:1942 NOTRY=true Committed: https://skia.googlesource.com/skia/+/0b7127635d8245de7ac704080d722d06e47621d0

Patch Set 1 #

Total comments: 5

Patch Set 2 : add --threads option to download images/generate diffs in parallel #

Patch Set 3 : allow summaries to be loaded directly from GS, and clean up UI #

Patch Set 4 : lots of cleanup #

Total comments: 6

Patch Set 5 : fix image URLs #

Total comments: 14

Patch Set 6 : Ravi comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+600 lines, -249 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gm/rebaseline_server/base_unittest.py View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download
M gm/rebaseline_server/compare_rendered_pictures.py View 1 2 3 4 5 5 chunks +182 lines, -92 lines 0 comments Download
M gm/rebaseline_server/compare_rendered_pictures_test.py View 1 2 3 4 5 2 chunks +11 lines, -6 lines 0 comments Download
M gm/rebaseline_server/imagediffdb.py View 1 2 3 4 5 11 chunks +170 lines, -50 lines 0 comments Download
M gm/rebaseline_server/imagepair.py View 1 2 3 4 chunks +23 lines, -14 lines 0 comments Download
M gm/rebaseline_server/imagepairset.py View 1 2 3 4 5 6 chunks +43 lines, -7 lines 0 comments Download
M gm/rebaseline_server/results.py View 1 2 3 4 5 1 chunk +15 lines, -4 lines 0 comments Download
M gm/rebaseline_server/server.py View 1 2 3 4 5 16 chunks +85 lines, -18 lines 0 comments Download
A + gm/rebaseline_server/static/live-loader.js View 1 2 3 4 5 4 chunks +9 lines, -4 lines 0 comments Download
A + gm/rebaseline_server/static/live-view.html View 1 2 3 4 5 3 chunks +10 lines, -7 lines 0 comments Download
M gm/rebaseline_server/testdata/outputs/expected/compare_rendered_pictures_test.CompareRenderedPicturesTest.test_endToEnd/compare_rendered_pictures.json View 1 2 3 4 8 chunks +44 lines, -44 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
epoger
This is NOT ready for review yet... I'll let you know when it is. As ...
6 years, 4 months ago (2014-07-31 15:18:31 UTC) #1
epoger
In patchset 2, I added a --threads option to download the images and generate diffs ...
6 years, 4 months ago (2014-07-31 21:25:42 UTC) #2
epoger
I ran some additional tests as of patchset 2 to figure out how much of ...
6 years, 4 months ago (2014-08-01 15:17:55 UTC) #3
rmistry
On 2014/08/01 15:17:55, epoger wrote: > I ran some additional tests as of patchset 2 ...
6 years, 4 months ago (2014-08-04 11:25:59 UTC) #4
epoger
> We should really make the rebaseline server a lot more beefier, it is only ...
6 years, 4 months ago (2014-08-04 12:50:04 UTC) #5
epoger
ALMOST ready for review as of patchset 3. More cleanup coming.
6 years, 4 months ago (2014-08-04 14:57:27 UTC) #6
epoger
OK, Ravi, ready for review at patchset 4! With this change, the rebaseline_server now provides ...
6 years, 4 months ago (2014-08-04 16:05:13 UTC) #7
epoger
On 2014/08/04 16:05:13, epoger wrote: > I've left it running... you can try it out ...
6 years, 4 months ago (2014-08-04 16:07:07 UTC) #8
rmistry
On 2014/08/04 16:05:13, epoger wrote: > OK, Ravi, ready for review at patchset 4! > ...
6 years, 4 months ago (2014-08-04 18:47:53 UTC) #9
epoger
On 2014/08/04 18:47:53, rmistry wrote: > On 2014/08/04 16:05:13, epoger wrote: > > OK, Ravi, ...
6 years, 4 months ago (2014-08-04 18:54:13 UTC) #10
rmistry
On 2014/08/04 18:54:13, epoger wrote: > On 2014/08/04 18:47:53, rmistry wrote: > > On 2014/08/04 ...
6 years, 4 months ago (2014-08-04 18:55:12 UTC) #11
epoger
> > I will change the URL construction and upload the modified CL. Thanks! In ...
6 years, 4 months ago (2014-08-04 19:05:34 UTC) #12
rmistry
https://codereview.chromium.org/424263005/diff/60001/gm/rebaseline_server/imagediffdb.py File gm/rebaseline_server/imagediffdb.py (right): https://codereview.chromium.org/424263005/diff/60001/gm/rebaseline_server/imagediffdb.py#newcode39 gm/rebaseline_server/imagediffdb.py:39: # the "too many open files" bug we saw ...
6 years, 4 months ago (2014-08-04 20:52:50 UTC) #13
rmistry
Lets also start CCing Stephan on rebaseline server's codereviews.
6 years, 4 months ago (2014-08-04 20:53:38 UTC) #14
epoger
Thanks, Ravi. Please see patchset 6. Now that I have changed the "actuals"/"expectations" naming to ...
6 years, 4 months ago (2014-08-05 03:34:09 UTC) #15
rmistry
LGTM https://codereview.chromium.org/424263005/diff/80001/gm/rebaseline_server/compare_rendered_pictures.py File gm/rebaseline_server/compare_rendered_pictures.py (right): https://codereview.chromium.org/424263005/diff/80001/gm/rebaseline_server/compare_rendered_pictures.py#newcode86 gm/rebaseline_server/compare_rendered_pictures.py:86: truncate_results: FOR TESTING ONLY: if True, truncate the ...
6 years, 4 months ago (2014-08-05 13:46:54 UTC) #16
epoger
The CQ bit was checked by epoger@google.com
6 years, 4 months ago (2014-08-05 17:05:13 UTC) #17
epoger
The CQ bit was unchecked by epoger@google.com
6 years, 4 months ago (2014-08-05 17:05:23 UTC) #18
epoger
The CQ bit was checked by epoger@google.com
6 years, 4 months ago (2014-08-05 17:06:05 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/424263005/100001
6 years, 4 months ago (2014-08-05 17:07:05 UTC) #20
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 17:07:27 UTC) #21
Message was sent while issue was closed.
Change committed as 0b7127635d8245de7ac704080d722d06e47621d0

Powered by Google App Engine
This is Rietveld 408576698