Issue 424213006: Extract PepperFileSystemTypeToFileSystemType() from ppapi.

Issue 424213006: Extract PepperFileSystemTypeToFileSystemType() from ppapi. (Closed)

Created:
6 years, 4 months ago by tfarina

Modified:
6 years, 4 months ago

Reviewers:
dmichael (off chromium), jam

CC:
chromium-reviews, darin (slow to review), jochen (gone - plz use gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Extract PepperFileSystemTypeToFileSystemType() from ppapi. This function is called only from within content to convert from a ppapi enum type to webkit fileapi type (this one will be come a content enum type in later change). So anticipating that change from webkit/ to content/ we moved this function from ppapi to content to make this future change a little bit easier. And it is also nice to do now because it removes the last include of webkit/ from ppapi making it much more clearer in term of deps. BUG=338338 TEST=blink_tests R=dmichael@chromium.org,jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286776

Patch Set 1 #

Total comments: 2

Patch Set 2 : looks like CONTENT_EXPORT is not needed? #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -25 lines)			Patch
M	content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc	View		4 chunks	+4 lines, -3 lines	0 comments	Download
A	content/common/pepper_file_util.h	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
A	content/common/pepper_file_util.cc	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	content/content_common.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_file_system_host.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	ppapi/shared_impl/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/shared_impl/file_system_util.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	ppapi/shared_impl/file_system_util.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	ppapi/shared_impl/host_resource.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm https://codereview.chromium.org/424213006/diff/1/content/common/pepper_file_util.h File content/common/pepper_file_util.h (right): https://codereview.chromium.org/424213006/diff/1/content/common/pepper_file_util.h#newcode14 content/common/pepper_file_util.h:14: CONTENT_EXPORT nit: probably don't need the CONTENT_EXPORT anymore

6 years, 4 months ago (2014-07-30 20:37:50 UTC) #2

tfarina

https://codereview.chromium.org/424213006/diff/1/content/common/pepper_file_util.h File content/common/pepper_file_util.h (right): https://codereview.chromium.org/424213006/diff/1/content/common/pepper_file_util.h#newcode14 content/common/pepper_file_util.h:14: CONTENT_EXPORT On 2014/07/30 20:37:50, jam wrote: > nit: probably ...

6 years, 4 months ago (2014-07-31 02:51:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/424213006/20001

6 years, 4 months ago (2014-07-31 02:54:48 UTC) #6

Message was sent while issue was closed.

Change committed as 286776

Expand Messages | Collapse Messages