Enable the WebIDL [Exposed] annotation on an interface's members.

Source/bindings/scripts/code_generator_v8.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 221 matching lines @@
         loader=jinja2.FileSystemLoader(templates_dir),
         # Bytecode cache is not concurrency-safe unless pre-cached:
         # if pre-cached this is read-only, but writing creates a race condition.
         bytecode_cache=jinja2.FileSystemBytecodeCache(cache_dir),
         keep_trailing_newline=True,  # newline-terminate generated files
         lstrip_blocks=True,  # so can indent control flow tags
         trim_blocks=True)
     jinja_env.filters.update({
         'blink_capitalize': capitalize,
         'conditional': conditional_if_endif,
+        'custom_exposed': custom_exposed_if,

[haraken, 2014/07/30 16:32:03]

"custom" is a bit confusing since "custom" implies custom bindings. I'd rename
this to simply "exposed".

[Peter Beverloo, 2014/07/31 19:02:21]

Done.

+        'per_context_enabled': per_context_enabled_if,
         'runtime_enabled': runtime_enabled_if,
         })
     return jinja_env
 
 
+def generate_indented_conditional(code, conditional):
+    # Indent if statement to level of original code
+    indent = re.match(' *', code).group(0)
+    return ('%sif (%s) {\n' % (indent, conditional) +
+            '    %s\n' % '\n    '.join(code.splitlines()) +
+            '%s}\n' % indent)
+
+
 # [Conditional]
 def conditional_if_endif(code, conditional_string):
     # Jinja2 filter to generate if/endif directive blocks
     if not conditional_string:
         return code
     return ('#if %s\n' % conditional_string +
             code +
             '#endif // %s\n' % conditional_string)
 
 
+# [Exposed]
+def custom_exposed_if(code, custom_exposed_rules):
+    if not custom_exposed_rules:
+        return code
+    return generate_indented_conditional(code, 'context && (%s)' % custom_exposed_rules)

[Jens Widell, 2014/07/30 16:48:45]

Can 'context' really be null? When does that happen?

[Peter Beverloo, 2014/07/31 19:02:21]

I'm not sure. The check existed in installPerContextEnabledMethods already so I
copied the logic.

Looking at v8::Object::CreationContext, there is a bailout case in which an
empty local will be returned, but I don't know enough about v8 to know when
that'd trigger. The toExecutionContext() method handles this case by returning
NULL.

We could ASSERT() on context being non-NULL in these methods, but then I'd
prefer to do that in a follow up patch.

+
+
+# [PerContextEnabled]
+def per_context_enabled_if(code, per_context_enabled_function):
+    if not per_context_enabled_function:
+        return code
+    return generate_indented_conditional(code, '%s(impl->document())' % per_context_enabled_function)
+
+
 # [RuntimeEnabled]
 def runtime_enabled_if(code, runtime_enabled_function_name):
     if not runtime_enabled_function_name:
         return code
-    # Indent if statement to level of original code
-    indent = re.match(' *', code).group(0)
-    return ('%sif (%s()) {\n' % (indent, runtime_enabled_function_name) +
-            '    %s\n' % '\n    '.join(code.splitlines()) +
-            '%s}\n' % indent)
+    return generate_indented_conditional(code, '%s()' % runtime_enabled_function_name)
 
 
 ################################################################################
 
 def main(argv):
     # If file itself executed, cache templates
     try:
         cache_dir = argv[1]
         dummy_filename = argv[2]
     except IndexError as err:
@@ skipping 10 matching lines @@
 
     # Create a dummy file as output for the build system,
     # since filenames of individual cache files are unpredictable and opaque
     # (they are hashes of the template path, which varies based on environment)
     with open(dummy_filename, 'w') as dummy_file:
         pass  # |open| creates or touches the file
 
 
 if __name__ == '__main__':
     sys.exit(main(sys.argv))