Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 424153002: Fix watchlists for clipboard. (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 4 months ago
Reviewers:
Rick Byers
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M WATCHLISTS View 1 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
Regexes are hard.
6 years, 4 months ago (2014-07-29 16:59:55 UTC) #1
Rick Byers
https://codereview.chromium.org/424153002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/424153002/diff/1/WATCHLISTS#newcode39 WATCHLISTS:39: 'filepath': 'Source/core/page/.*Drag', The RegEx change makes sense, but don't ...
6 years, 4 months ago (2014-07-29 17:52:22 UTC) #2
dcheng
https://codereview.chromium.org/424153002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/424153002/diff/1/WATCHLISTS#newcode39 WATCHLISTS:39: 'filepath': 'Source/core/page/.*Drag', On 2014/07/29 17:52:22, Rick Byers wrote: > ...
6 years, 4 months ago (2014-07-29 18:09:36 UTC) #3
Rick Byers
LGTM
6 years, 4 months ago (2014-07-29 18:11:34 UTC) #4
dcheng
6 years, 4 months ago (2014-07-29 18:16:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r179167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698