The street view in Google maps, which is implemented with a windowed flash pl...

webkit/glue/webplugin_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "webkit/glue/webplugin_impl.h"
 
 #include "Cursor.h"
 #include "Document.h"
 #include "DocumentLoader.h"
@@ skipping 113 matching lines @@
 }
 
 #if USE(JSC)
 bool WebPluginContainer::isPluginView() const {
   return true;
 }
 #endif
 
 
 void WebPluginContainer::setFrameRect(const WebCore::IntRect& rect) {
-  // WebKit calls move every time it paints (see RenderWidget::paint).  No need
-  // to do expensive operations if we didn't actually move.
-  if (rect == frameRect())
-    return;
+  bool widget_dimensions_changed = (rect != frameRect());
 
-  WebCore::Widget::setFrameRect(rect);
-  impl_->setFrameRect(rect);
+  if (widget_dimensions_changed)
+    WebCore::Widget::setFrameRect(rect);
+
+  impl_->setFrameRect(rect, widget_dimensions_changed);
 }
 
 void WebPluginContainer::paint(WebCore::GraphicsContext* gc,
                                const WebCore::IntRect& damage_rect) {
   // In theory, we should call impl_->print(gc); when
   // impl_->webframe_->printing() is true but it still has placement issues so
   // keep that code off for now.
   impl_->paint(gc, damage_rect);
 }
 
@@ skipping 39 matching lines @@
 }
 
 void WebPluginContainer::handleEvent(WebCore::Event* event) {
   impl_->handleEvent(event);
 }
 
 void WebPluginContainer::frameRectsChanged() {
   WebCore::Widget::frameRectsChanged();
   // This is a hack to tickle re-positioning of the plugin in the case where
   // our parent view was scrolled.
-  impl_->setFrameRect(frameRect());
+  impl_->setFrameRect(frameRect(), true);
 }
 
 // We override this function, to make sure that geometry updates are sent
 // over to the plugin. For e.g. when a plugin is instantiated it does
 // not have a valid parent. As a result the first geometry update from
 // webkit is ignored. This function is called when the plugin eventually
 // gets a parent.
 void WebPluginContainer::setParentVisible(bool visible) {
   WebCore::Widget::setParentVisible(visible);
   if (visible)
     show();
   else
     hide();
 }
 
 // We override this function so that if the plugin is windowed, we can call
 // NPP_SetWindow at the first possible moment.  This ensures that NPP_SetWindow
 // is called before the manual load data is sent to a plugin.  If this order is
 // reversed, Flash won't load videos.
 void WebPluginContainer::setParent(WebCore::ScrollView* view) {
   WebCore::Widget::setParent(view);
   if (view) {
-    impl_->setFrameRect(frameRect());
+    impl_->setFrameRect(frameRect(), true);
     impl_->delegate_->FlushGeometryUpdates();
   }
 }
 
 void WebPluginContainer::windowCutoutRects(const WebCore::IntRect& bounds,
                                            WTF::Vector<WebCore::IntRect>*
                                            cutouts) const {
   impl_->windowCutoutRects(bounds, cutouts);
 }
 
@@ skipping 397 matching lines @@
           WebCore::IntPoint point = roundedIntPoint(ro->localToAbsolute());
           WebCore::RenderBox* rbox = WebCore::toRenderBox(ro);
           WebCore::IntSize size(rbox->width(), rbox->height());
           cutouts->append(WebCore::IntRect(point, size));
         }
       }
     }
   }
 }
 
-void WebPluginImpl::setFrameRect(const WebCore::IntRect& rect) {
+void WebPluginImpl::setFrameRect(const WebCore::IntRect& rect,
+                                 bool widget_dimensions_changed) {
   if (!parent())
     return;
 
   // Compute a new position and clip rect for ourselves relative to the
   // containing window.  We ask our delegate to reposition us accordingly.
   WebCore::Frame* frame = element_->document()->frame();
   WebFrameImpl* webframe = WebFrameImpl::FromFrame(frame);
   WebViewImpl* webview = webframe->webview_impl();
   // It is valid for this function to be invoked in code paths where the
   // the webview is closed.
   if (!webview->delegate()) {
     return;
   }
 
   WebCore::IntRect window_rect;
   WebCore::IntRect clip_rect;
   std::vector<gfx::Rect> cutout_rects;
   CalculateBounds(rect, &window_rect, &clip_rect, &cutout_rects);
 
-  delegate_->UpdateGeometry(
-      webkit_glue::FromIntRect(window_rect),
-      webkit_glue::FromIntRect(clip_rect));
+  if (widget_dimensions_changed) {
+    delegate_->UpdateGeometry(
+        webkit_glue::FromIntRect(window_rect),
+        webkit_glue::FromIntRect(clip_rect));
+  }
 
   if (window_) {
     // Let the WebViewDelegate know that the plugin window needs to be moved,
     // so that all the HWNDs are moved together.
     WebPluginGeometry move;
     move.window = window_;
     move.window_rect = webkit_glue::FromIntRect(window_rect);
     move.clip_rect = webkit_glue::FromIntRect(clip_rect);
     move.cutout_rects = cutout_rects;
     move.visible = visible_;
@@ skipping 749 matching lines @@
     client_index = clients_.erase(client_index);
     if (resource_client)
       resource_client->DidFail();
   }
 
   // This needs to be called now and not in the destructor since the
   // webframe_ might not be valid anymore.
   webframe_->set_plugin_delegate(NULL);
   webframe_ = NULL;
 }