Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Issue 424093002: Fix Object.freeze with field type tracking. (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix Object.freeze with field type tracking. Keep the descriptor properly intact while update the field type. BUG=v8:3458 LOG=y R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M src/objects.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +13 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-update-field-type-attributes.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-07-29 11:19:37 UTC) #1
Jakob Kummerow
lgtm
6 years, 4 months ago (2014-07-29 11:30:31 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-07-29 13:30:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22671 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698