Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 424083002: Split out const/non-const variants of Resource::resourceRequest(). (Closed)

Created:
6 years, 4 months ago by Mike West
Modified:
6 years, 4 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Split out const/non-const variants of Resource::resourceRequest(). This patch follows the general convention of *::resourceRequest() and *::mutableResourceRequest() from various other classes which use ResourceRequest objects (FetchRequest, NavigationAction, etc). As a drive-by, it also consts Resource::lastResourceRequest(), which was already returning a const reference. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M Source/core/fetch/Resource.h View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/fetch/Resource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceLoadPriorityOptimizer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Mike West
Mind taking a quick look at this cleanup CL?
6 years, 4 months ago (2014-07-29 10:59:45 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-29 11:26:51 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 4 months ago (2014-07-29 11:42:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/424083002/1
6 years, 4 months ago (2014-07-29 11:42:57 UTC) #4
Mike West
The CQ bit was unchecked by mkwst@chromium.org
6 years, 4 months ago (2014-07-29 12:59:53 UTC) #5
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 4 months ago (2014-07-29 13:00:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/424083002/1
6 years, 4 months ago (2014-07-29 13:00:16 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 13:00:47 UTC) #8
Message was sent while issue was closed.
Change committed as 179143

Powered by Google App Engine
This is Rietveld 408576698