Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 424043002: GN: Fix nacl_defines used in chrome/browser (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
brettw, noelallen1
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

GN: Fix nacl_defines used in chrome/browser chrome/browser/ was using a nacl_defines set from //native_client/..., which is not the same as the nacl_defines used by the gyp build in //components/nacl/. In particular, defining _XOPEN_SOURCE=600 breaks compilation on mac in highly mysterious ways. This adds a //components/nacl/nacl_defines.gni that mirros the defines in //components/nacl/nacl_defines.gypi to bring the builds back in line with each other. R=brettw@chromium.org TBR=noelallen@chromium.org for components/nacl Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A components/nacl/nacl_defines.gni View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
6 years, 4 months ago (2014-07-29 05:58:47 UTC) #1
brettw
6 years, 4 months ago (2014-07-29 20:37:47 UTC) #2
brettw
lgtm
6 years, 4 months ago (2014-07-29 20:37:51 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-07-29 22:13:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/424043002/1
6 years, 4 months ago (2014-07-29 22:16:33 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 22:43:58 UTC) #6
Message was sent while issue was closed.
Change committed as 286322

Powered by Google App Engine
This is Rietveld 408576698