Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: mojo/shell/dynamic_service_loader_unittest.cc

Issue 423963004: First cut at "content handling" support in Mojo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use URLResponse with ContentHandler interface instead of data pipe Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/dynamic_service_loader_unittest.cc
diff --git a/mojo/shell/dynamic_service_loader_unittest.cc b/mojo/shell/dynamic_service_loader_unittest.cc
index 7cfb74b171976001fb8f3485d0edd8a8a4d960bb..7f0cd14ec08b8d7b285b43426f2a1d875b0d4c8c 100644
--- a/mojo/shell/dynamic_service_loader_unittest.cc
+++ b/mojo/shell/dynamic_service_loader_unittest.cc
@@ -72,10 +72,11 @@ TEST_F(DynamicServiceLoaderTest, DoesNotExist) {
base::FilePath nonexistent_file(FILE_PATH_LITERAL("nonexistent.txt"));
GURL url(net::FilePathToFileURL(temp_dir.path().Append(nonexistent_file)));
MessagePipe pipe;
- loader_->LoadService(context_.service_manager(), url, pipe.handle0.Pass());
- loop_.Run();
+ scoped_refptr<ServiceLoader::SimpleLoadServiceCallbacks> callbacks(
+ new ServiceLoader::SimpleLoadServiceCallbacks(pipe.handle0.Pass()));
+ loader_->LoadService(context_.service_manager(), url, callbacks);
EXPECT_FALSE(state_.runner_was_started);
- EXPECT_TRUE(state_.runner_was_destroyed);
+ EXPECT_FALSE(state_.runner_was_destroyed);
}
} // namespace shell

Powered by Google App Engine
This is Rietveld 408576698