Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: mojo/shell/ui_service_loader_android.cc

Issue 423963004: First cut at "content handling" support in Mojo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more gn Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/ui_service_loader_android.h ('k') | mojo/shell/view_manager_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/ui_service_loader_android.cc
diff --git a/mojo/shell/ui_service_loader_android.cc b/mojo/shell/ui_service_loader_android.cc
index 3960858c2f73ad165f980c1ebd6799c3e802d4ad..e2f77464bf8d05fb753809263b1740c08d975715 100644
--- a/mojo/shell/ui_service_loader_android.cc
+++ b/mojo/shell/ui_service_loader_android.cc
@@ -15,10 +15,12 @@ class UIServiceLoader::UILoader {
explicit UILoader(ServiceLoader* loader) : loader_(loader) {}
~UILoader() {}
- void LoadService(ServiceManager* manager,
- const GURL& url,
- ScopedMessagePipeHandle shell_handle) {
- loader_->LoadService(manager, url, shell_handle.Pass());
+ void Load(ServiceManager* manager,
+ const GURL& url,
+ ScopedMessagePipeHandle shell_handle) {
+ scoped_refptr<LoadCallbacks> callbacks(
+ new ServiceLoader::SimpleLoadCallbacks(shell_handle.Pass()));
+ loader_->Load(manager, url, callbacks);
}
void OnServiceError(ServiceManager* manager, const GURL& url) {
@@ -42,17 +44,20 @@ UIServiceLoader::~UIServiceLoader() {
base::Bind(&UIServiceLoader::ShutdownOnUIThread, base::Unretained(this)));
}
-void UIServiceLoader::LoadService(ServiceManager* manager,
- const GURL& url,
- ScopedMessagePipeHandle shell_handle) {
+void UIServiceLoader::Load(ServiceManager* manager,
+ const GURL& url,
+ scoped_refptr<LoadCallbacks> callbacks) {
+ ScopedMessagePipeHandle shell_handle = callbacks->RegisterApplication();
+ if (!shell_handle.is_valid())
+ return;
context_->ui_loop()->PostTask(
FROM_HERE,
- base::Bind(
- &UIServiceLoader::LoadServiceOnUIThread,
- base::Unretained(this),
- manager,
- url,
- base::Owned(new ScopedMessagePipeHandle(shell_handle.Pass()))));
+ base::Bind(&UIServiceLoader::LoadOnUIThread,
+ base::Unretained(this),
+ manager,
+ url,
+ base::Owned(
+ new ScopedMessagePipeHandle(shell_handle.Pass()))));
}
void UIServiceLoader::OnServiceError(ServiceManager* manager, const GURL& url) {
@@ -64,13 +69,12 @@ void UIServiceLoader::OnServiceError(ServiceManager* manager, const GURL& url) {
url));
}
-void UIServiceLoader::LoadServiceOnUIThread(
- ServiceManager* manager,
- const GURL& url,
- ScopedMessagePipeHandle* shell_handle) {
+void UIServiceLoader::LoadOnUIThread(ServiceManager* manager,
+ const GURL& url,
+ ScopedMessagePipeHandle* shell_handle) {
if (!ui_loader_)
ui_loader_ = new UILoader(loader_.get());
- ui_loader_->LoadService(manager, url, shell_handle->Pass());
+ ui_loader_->Load(manager, url, shell_handle->Pass());
}
void UIServiceLoader::OnServiceErrorOnUIThread(ServiceManager* manager,
« no previous file with comments | « mojo/shell/ui_service_loader_android.h ('k') | mojo/shell/view_manager_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698