First cut at "content handling" support in Mojo.

mojo/shell/dynamic_service_loader_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/scoped_temp_dir.h"
 #include "mojo/shell/context.h"
 #include "mojo/shell/dynamic_service_loader.h"
-#include "mojo/shell/dynamic_service_runner.h"
+#include "mojo/shell/in_process_dynamic_service_runner.h"
 #include "net/base/filename_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace mojo {
 namespace shell {
 
 namespace {
 
 struct TestState {
   TestState() : runner_was_started(false), runner_was_destroyed(false) {}
   bool runner_was_started;
   bool runner_was_destroyed;
 };
 
-class TestDynamicServiceRunner : public DynamicServiceRunner {
+class TestDynamicServiceRunner : public InProcessDynamicServiceRunner {
  public:
-  explicit TestDynamicServiceRunner(TestState* state) : state_(state) {}
+  explicit TestDynamicServiceRunner(Context* context, TestState* state)

[tim (not reviewing), 2014/08/05 23:52:37]

nit - don't need explicit

+      : InProcessDynamicServiceRunner(context), state_(state) {}
   virtual ~TestDynamicServiceRunner() {
     state_->runner_was_destroyed = true;
-    base::MessageLoop::current()->Quit();
   }
   virtual void Start(const base::FilePath& app_path,
                      ScopedMessagePipeHandle service_handle,
                      const base::Closure& app_completed_callback) OVERRIDE {
     state_->runner_was_started = true;
+    InProcessDynamicServiceRunner::Start(app_path, service_handle.Pass(),

[tim (not reviewing), 2014/08/05 23:52:37]

What is using a real InProcessDSR buying us?

[Aaron Boodman, 2014/08/06 00:37:22]

It's not needed with the current patch, I had the change in by mistake. I've
reverted it.

I think it was needed in one version of the code in order to get
app_completed_callback to run. But I can't remember exactly anymore. I think I
need dinner.

+                                         app_completed_callback);
   }
  private:
   TestState* state_;
 };
 
 class TestDynamicServiceRunnerFactory : public DynamicServiceRunnerFactory {
  public:
   explicit TestDynamicServiceRunnerFactory(TestState* state) : state_(state) {}
   virtual ~TestDynamicServiceRunnerFactory() {}
   virtual scoped_ptr<DynamicServiceRunner> Create(Context* context) OVERRIDE {
     return scoped_ptr<DynamicServiceRunner>(
-        new TestDynamicServiceRunner(state_));
+        new TestDynamicServiceRunner(context, state_));
   }
  private:
   TestState* state_;
 };
 
 }  // namespace
 
 class DynamicServiceLoaderTest : public testing::Test {
  public:
   DynamicServiceLoaderTest() {}
@@ skipping 10 matching lines @@
   scoped_ptr<DynamicServiceLoader> loader_;
   TestState state_;
 };
 
 TEST_F(DynamicServiceLoaderTest, DoesNotExist) {
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   base::FilePath nonexistent_file(FILE_PATH_LITERAL("nonexistent.txt"));
   GURL url(net::FilePathToFileURL(temp_dir.path().Append(nonexistent_file)));
   MessagePipe pipe;
-  loader_->LoadService(context_.service_manager(), url, pipe.handle0.Pass());
+  scoped_refptr<ServiceLoader::SimpleLoadServiceCallbacks> callbacks(
+      new ServiceLoader::SimpleLoadServiceCallbacks(pipe.handle0.Pass()));
+  loader_->LoadService(context_.service_manager(), url, callbacks);
   loop_.Run();
-  EXPECT_FALSE(state_.runner_was_started);
+  EXPECT_TRUE(state_.runner_was_started);
   EXPECT_TRUE(state_.runner_was_destroyed);
 }
 
 }  // namespace shell
 }  // namespace mojo