Tidy up app::response().

fpdfsdk/src/javascript/app.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 135 matching lines @@
                 ASSERT(pApp != NULL);
 
                 CJS_Runtime* pRuntime = pContext->GetJSRuntime();
                 ASSERT(pRuntime != NULL);
                 
                 CPDFSDK_Document* pCurDoc = pContext->GetReaderDocument();
                 
                 CJS_Array aDocs(pRuntime->GetIsolate());
 //              int iNumDocs = pApp->CountDocuments();
                 
-//              for(int iIndex = 0; iIndex<iNumDocs; iIndex++)
-//              {
+//              for(int iIndex = 0; iIndex<iNumDocs; iIndex++)
+//              {
                         CPDFSDK_Document* pDoc = pApp->GetCurrentDoc();
                         if (pDoc)
                         {
                                 CJS_Document * pJSDocument = NULL;
                                 
                                 if (pDoc == pCurDoc)
                                 {
                                         JSFXObject pObj = JS_GetThisObj(*pRuntime);
                                         
                                         if (JS_GetObjDefnID(pObj) == JS_GetObjDefnID(*pRuntime, L"Document"))
@@ skipping 35 matching lines @@
                 CJS_Context* pContext = (CJS_Context*)cc;
                 ASSERT(pContext != NULL);
                 
                 CPDFDoc_Environment* pApp = pContext->GetReaderApp();
                 ASSERT(pApp != NULL);
                 
                 CJS_Runtime* pRuntime = pContext->GetJSRuntime();
                 ASSERT(pRuntime != NULL);
 
                 CJS_Array aDocs(pRuntime->GetIsolate());
-//              int iNumDocs = pApp->CountDocuments();
-//              
-//              for (int iIndex = 0;iIndex < iNumDocs; iIndex++)
-//              {
+//              int iNumDocs = pApp->CountDocuments();
+//              
+//              for (int iIndex = 0;iIndex < iNumDocs; iIndex++)
+//              {
                         if (CPDFSDK_Document* pDoc = pApp->GetCurrentDoc())
                         {
                                 CPDFSDK_InterForm* pInterForm = (CPDFSDK_InterForm*)pDoc->GetInterForm();
                                 ASSERT(pInterForm != NULL);
                                 pInterForm->EnableCalculate((FX_BOOL)m_bCalculate);
                         }                       
 //              }
         }
         else
         {
@@ skipping 17 matching lines @@
 FX_BOOL app::viewerType(OBJ_PROP_PARAMS)
 {
 
 
         
         
         
 
         if (vp.IsGetting())
         {
-//              if (pApp->GetAppName() == PHANTOM)
-//                      vp << JS_STR_VIEWERTYPE_STANDARD;
-//              else
-//                      vp << JS_STR_VIEWERTYPE_READER;
+//              if (pApp->GetAppName() == PHANTOM)
+//                      vp << JS_STR_VIEWERTYPE_STANDARD;
+//              else
+//                      vp << JS_STR_VIEWERTYPE_READER;
                 vp << L"unknown";
 
                 //vp << pApp->GetAppTitle();
                 return TRUE;
         }
         
         return FALSE;
 }
 
 FX_BOOL app::viewerVariation(OBJ_PROP_PARAMS)
@@ skipping 92 matching lines @@
 
                         if (swMsg == L"")
                         {
                                 CJS_Array carray(isolate);
                                 if (params[0].ConvertToArray(carray))
                                 {
                                         int iLenth = carray.GetLength();
                                         CJS_Value* pValue = new CJS_Value(isolate);
 //                                      if (iLenth == 1)
 //                                              pValue = new CJS_Value(isolate);
-//                                      else if (iLenth > 1)
-//                                              pValue = new CJS_Value[iLenth];
+//                                      else if (iLenth > 1)
+//                                              pValue = new CJS_Value[iLenth];
 
                                         for(int i = 0; i < iLenth; i++)
                                         {
                                                 carray.GetElement(i, *pValue);
                                                 swMsg += (*pValue).operator CFX_WideString();
                                                 if (i < iLenth - 1)
                                                         swMsg += L",  ";
                                         }
 
                                         if(pValue) delete pValue;
-//                                      if ((iLenth > 1) && pValue)
-//                                      {
-//                                              delete[]pValue;
-//                                              pValue = NULL;
-//                                      }
-//                                      else if ((iLenth == 1) && pValue)
-//                                      {
-//                                              delete pValue;
-//                                              pValue = NULL;
-//                                      }
+//                                      if ((iLenth > 1) && pValue)
+//                                      {
+//                                              delete[]pValue;
+//                                              pValue = NULL;
+//                                      }
+//                                      else if ((iLenth == 1) && pValue)
+//                                      {
+//                                              delete pValue;
+//                                              pValue = NULL;
+//                                      }
                                 }
                         }
 
                         if (swTitle == L"")
                                 swTitle = JSGetStringFromID((CJS_Context*)cc, IDS_STRING_JSALERT);
                 }
                 else if (params[0].GetType() == VT_boolean)
                 {
                         FX_BOOL bGet = (FX_BOOL)params[0];
                         if (bGet)
@@ skipping 538 matching lines @@
 
         if (!cFSInit.IsEmpty())
         {
                 JS_PutObjectString(isolate,pRetObj, L"cFS", CFX_WideString::FromLocal(cFSInit.GetBuffer(cFSInit.GetLength())));
         }
         else
         {
                 JS_PutObjectString(isolate,pRetObj, L"cFS", CFX_WideString::FromLocal("DOS"));
         }
         
-        vRet =  pRetObj;
+        vRet =  pRetObj;
 
         return TRUE;
 }
 
 CFX_WideString app::SysPathToPDFPath(const CFX_WideString& sOldPath)
 {
         CFX_WideString sRet = L"/";
         
         for (int i=0,sz=sOldPath.GetLength(); i<sz; i++)
         {
@@ skipping 69 matching lines @@
 FX_BOOL app::response(OBJ_METHOD_PARAMS)
 {
         CFX_WideString swQuestion = L"";
         CFX_WideString swLabel = L"";
 #ifndef FOXIT_CHROME_BUILD
         CFX_WideString swTitle = L"Foxit";
 #else
         CFX_WideString swTitle = L"PDF";
 #endif
         CFX_WideString swDefault = L"";
-        CFX_WideString swResponse = L"";
         bool bPassWord = false;
-        
+
         v8::Isolate* isolate = GetIsolate(cc);
-        
-        int iLength = params.size();    
+
+        int iLength = params.size();
         if (iLength > 0 && params[0].GetType() == VT_object)
         {
-                
                 JSObject pObj = (JSObject )params[0];
                 v8::Handle<v8::Value> pValue = JS_GetObjectElement(isolate,pObj,L"cQuestion");
                         swQuestion = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
 
                 pValue = JS_GetObjectElement(isolate,pObj,L"cTitle");
                         swTitle = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
 
                 pValue = JS_GetObjectElement(isolate,pObj,L"cDefault");
                         swDefault = CJS_Value(isolate,pValue,GET_VALUE_TYPE(pValue)).operator CFX_WideString();
 
@@ skipping 35 matching lines @@
                 default:
                         break;
                 }
         }
 
         CJS_Context* pContext = (CJS_Context *)cc;
         ASSERT(pContext != NULL);
 
         CPDFDoc_Environment* pApp = pContext->GetReaderApp();
         ASSERT(pApp != NULL);
-        int nLength = 2048;
-        char* pBuff = new char[nLength];
-        nLength = pApp->JS_appResponse(swQuestion, swTitle, swDefault, swLabel, bPassWord, pBuff, nLength);
-        if(nLength<=0)
+
+        const int MAX_INPUT_BYTES = 2048;
+        char* pBuff = new char[MAX_INPUT_BYTES + 2];
+        if (!pBuff)
+                return FALSE;
+
+        memset(pBuff, 0, MAX_INPUT_BYTES + 2);
+        int nLengthBytes = pApp->JS_appResponse(swQuestion, swTitle, swDefault, swLabel, bPassWord, pBuff, MAX_INPUT_BYTES);
+        if (nLengthBytes <= 0)
         {
+                vRet.SetNull();
                 delete[] pBuff;
-                vRet.SetNull();
                 return FALSE;
         }
-        else
-        {
-                nLength = nLength > sizeof(pBuff) ? sizeof(pBuff) : nLength;
-        vRet = swResponse = CFX_WideString::FromUTF16LE((unsigned short*)pBuff, nLength / 2);
-        }
+        if (nLengthBytes > MAX_INPUT_BYTES)
+                nLengthBytes = MAX_INPUT_BYTES;
+
+        vRet = CFX_WideString::FromUTF16LE((unsigned short*)pBuff, nLengthBytes);
         delete[] pBuff;
-
         return TRUE;
 }
 
 FX_BOOL app::media(OBJ_PROP_PARAMS)
 {
         return FALSE;
 }
 
 FX_BOOL app::execDialog(OBJ_METHOD_PARAMS)
 {
         return TRUE;
 }