Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 423943004: Remove stray comment about ConvertableToTraceFormat (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1612 matching lines...) Expand 10 before | Expand all | Expand 10 after
1623 return false; // Don't invalidate paints if we're printing. 1623 return false; // Don't invalidate paints if we're printing.
1624 1624
1625 const LayoutRect& newBounds = previousPaintInvalidationRect(); 1625 const LayoutRect& newBounds = previousPaintInvalidationRect();
1626 const LayoutPoint& newLocation = previousPositionFromPaintInvalidationContai ner(); 1626 const LayoutPoint& newLocation = previousPositionFromPaintInvalidationContai ner();
1627 1627
1628 // FIXME: PaintInvalidationState should not be required here, but the call t o flipForWritingMode 1628 // FIXME: PaintInvalidationState should not be required here, but the call t o flipForWritingMode
1629 // in mapRectToPaintInvalidationBacking will give us the wrong results with it disabled. 1629 // in mapRectToPaintInvalidationBacking will give us the wrong results with it disabled.
1630 // crbug.com/393762 1630 // crbug.com/393762
1631 ASSERT(newBounds == boundsRectForPaintInvalidation(&paintInvalidationContain er, &paintInvalidationState)); 1631 ASSERT(newBounds == boundsRectForPaintInvalidation(&paintInvalidationContain er, &paintInvalidationState));
1632 1632
1633 // FIXME: This should use a ConvertableToTraceFormat when they are available in Blink.
1634 TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("blink.invalidation"), "RenderObject: :invalidatePaintIfNeeded()", 1633 TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("blink.invalidation"), "RenderObject: :invalidatePaintIfNeeded()",
1635 "object", this->debugName().ascii(), 1634 "object", this->debugName().ascii(),
1636 "info", jsonObjectForOldAndNewRects(oldBounds, newBounds)); 1635 "info", jsonObjectForOldAndNewRects(oldBounds, newBounds));
1637 1636
1638 InvalidationReason invalidationReason = getPaintInvalidationReason(paintInva lidationContainer, oldBounds, oldLocation, newBounds, newLocation); 1637 InvalidationReason invalidationReason = getPaintInvalidationReason(paintInva lidationContainer, oldBounds, oldLocation, newBounds, newLocation);
1639 1638
1640 if (invalidationReason == InvalidationNone) 1639 if (invalidationReason == InvalidationNone)
1641 return false; 1640 return false;
1642 1641
1643 if (invalidationReason == InvalidationIncremental) { 1642 if (invalidationReason == InvalidationIncremental) {
(...skipping 1804 matching lines...) Expand 10 before | Expand all | Expand 10 after
3448 { 3447 {
3449 if (object1) { 3448 if (object1) {
3450 const blink::RenderObject* root = object1; 3449 const blink::RenderObject* root = object1;
3451 while (root->parent()) 3450 while (root->parent())
3452 root = root->parent(); 3451 root = root->parent();
3453 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3452 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3454 } 3453 }
3455 } 3454 }
3456 3455
3457 #endif 3456 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698