Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 423943002: Remove comment about issue 368416 (Closed)

Created:
6 years, 4 months ago by Julien - ping for review
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove comment about issue 368416 Since the issue was opened, the validity of removing RenderObject::positionFromPaintInvalidationContainer was questioned and it was determined that it's probably not such a good idea anyway. BUG=368416 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Julien - ping for review
6 years, 4 months ago (2014-07-28 19:34:02 UTC) #1
dsinclair
lgtm
6 years, 4 months ago (2014-07-28 19:34:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/423943002/1
6 years, 4 months ago (2014-07-28 19:35:30 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-28 20:40:36 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 20:53:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/39061)
6 years, 4 months ago (2014-07-28 20:53:41 UTC) #6
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 4 months ago (2014-07-29 00:54:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/423943002/1
6 years, 4 months ago (2014-07-29 00:55:16 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 00:56:07 UTC) #9
Message was sent while issue was closed.
Change committed as 179078

Powered by Google App Engine
This is Rietveld 408576698