Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 423833002: Check if the delegate changed the visibility of child MenuItemViews. (Closed)

Created:
6 years, 4 months ago by Joao da Silva
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Check if the delegate changed the visibility of child MenuItemViews. This is used by the BookmarkContextMenu to hide the "Show Managed Bookmarks" option when that policy is not set. BUG=397950 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286163

Patch Set 1 #

Patch Set 2 : Added test #

Total comments: 2

Patch Set 3 : Added MenuModelAdapter::IsCommandVisible #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -3 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_context_menu.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_unittest.cc View 1 3 chunks +54 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_model_adapter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/menu/menu_model_adapter.cc View 1 2 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Joao da Silva
This fixes an issue where the "Show managed bookmarks" option is always being shown in ...
6 years, 4 months ago (2014-07-28 12:59:34 UTC) #1
sky
https://codereview.chromium.org/423833002/diff/20001/ui/views/controls/menu/menu_item_view.cc File ui/views/controls/menu/menu_item_view.cc (right): https://codereview.chromium.org/423833002/diff/20001/ui/views/controls/menu/menu_item_view.cc#newcode257 ui/views/controls/menu/menu_item_view.cc:257: if (GetDelegate() && !GetDelegate()->IsCommandVisible(item_id)) Can you also update MenuModelAdapter. ...
6 years, 4 months ago (2014-07-28 15:53:17 UTC) #2
Joao da Silva
https://codereview.chromium.org/423833002/diff/20001/ui/views/controls/menu/menu_item_view.cc File ui/views/controls/menu/menu_item_view.cc (right): https://codereview.chromium.org/423833002/diff/20001/ui/views/controls/menu/menu_item_view.cc#newcode257 ui/views/controls/menu/menu_item_view.cc:257: if (GetDelegate() && !GetDelegate()->IsCommandVisible(item_id)) On 2014/07/28 15:53:17, sky wrote: ...
6 years, 4 months ago (2014-07-28 16:12:49 UTC) #3
sky
LGTM
6 years, 4 months ago (2014-07-28 19:01:08 UTC) #4
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 4 months ago (2014-07-29 07:10:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/423833002/40001
6 years, 4 months ago (2014-07-29 07:12:40 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 10:38:06 UTC) #7
Message was sent while issue was closed. 
Change committed as 286163

Powered by Google App Engine
This is Rietveld 408576698