Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: Source/core/rendering/RenderLayer.h

Issue 423823004: Add support for SVG Clip paths in HTML (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unwanted code from RenderLayerClipPathInfo.* and Renderlayer.cpp and Renamed filters to svg… Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderLayer.h
diff --git a/Source/core/rendering/RenderLayer.h b/Source/core/rendering/RenderLayer.h
index 5871a502fb9036b79b1d2b1bb0f9a6679b22da5e..debff6614e6ab251528bf71449ac377b8744ba49 100644
--- a/Source/core/rendering/RenderLayer.h
+++ b/Source/core/rendering/RenderLayer.h
@@ -49,6 +49,7 @@
#include "core/rendering/LayerPaintingInfo.h"
#include "core/rendering/RenderBox.h"
#include "core/rendering/RenderLayerBlendInfo.h"
+#include "core/rendering/RenderLayerClipPathInfo.h"
#include "core/rendering/RenderLayerClipper.h"
#include "core/rendering/RenderLayerFilterInfo.h"
#include "core/rendering/RenderLayerReflectionInfo.h"
@@ -302,7 +303,7 @@ public:
// FIXME: reflections should force transform-style to be flat in the style: https://bugs.webkit.org/show_bug.cgi?id=106959
bool shouldPreserve3D() const { return !renderer()->hasReflection() && renderer()->style()->transformStyle3D() == TransformStyle3DPreserve3D; }
- void filterNeedsPaintInvalidation();
+ void SVGEffectsNeedsPaintInvalidation();
pdr. 2014/08/04 17:06:32 We should use "svgEffectsNeedPaintInvalidation" (l
f(malita) 2014/08/05 14:13:07 +1.
Shanmuga Pandi 2014/08/06 14:51:34 Done.
bool hasFilter() const { return renderer()->hasFilter(); }
bool paintsWithBlendMode() const;
@@ -643,6 +644,8 @@ private:
void updateReflectionInfo(const RenderStyle*);
+ void updateClipPathInfo(const RenderStyle* oldStyle, const RenderStyle* newStyle);
+
// FIXME: We could lazily allocate our ScrollableArea based on style properties ('overflow', ...)
// but for now, we are always allocating it for RenderBox as it's safer.
bool requiresScrollableArea() const { return renderBox(); }
@@ -770,6 +773,7 @@ private:
RenderLayerClipper m_clipper; // FIXME: Lazily allocate?
OwnPtr<RenderLayerStackingNode> m_stackingNode;
OwnPtr<RenderLayerReflectionInfo> m_reflectionInfo;
+ OwnPtr<RenderLayerClipPathInfo> m_clipPathInfo;
f(malita) 2014/08/05 14:13:08 This increases the size of all RenderLayers, but v
Shanmuga Pandi 2014/08/06 14:51:34 Initially I tried that way (Patch set1). But I tho
RenderLayerBlendInfo m_blendInfo;
LayoutSize m_subpixelAccumulation; // The accumulated subpixel offset of a composited layer's composited bounds compared to absolute coordinates.

Powered by Google App Engine
This is Rietveld 408576698