Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 423823004: Add support for SVG Clip paths in HTML (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Try to correct A+ mode Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderLayer.cpp
diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp
index ea83bc9e465458e5b59d3e73b430a8b72a3eb3e3..17401aeda2daafa8fe6154e781412250bc707934 100644
--- a/Source/core/rendering/RenderLayer.cpp
+++ b/Source/core/rendering/RenderLayer.cpp
@@ -118,6 +118,7 @@ RenderLayer::RenderLayer(RenderLayerModelObject* renderer, LayerType type)
, m_has3DTransformedDescendant(false)
, m_containsDirtyOverlayScrollbars(false)
, m_hasFilterInfo(false)
+ , m_hasClipPathInfo(false)
, m_needsAncestorDependentCompositingInputsUpdate(true)
, m_needsDescendantDependentCompositingInputsUpdate(true)
, m_childNeedsCompositingInputsUpdate(true)
@@ -162,6 +163,7 @@ RenderLayer::~RenderLayer()
}
removeFilterInfoIfNeeded();
+ removeClipPathInfoIfNeeded();
if (groupedMapping()) {
DisableCompositingQueryAsserts disabler;
@@ -3549,6 +3551,27 @@ void RenderLayer::updateFilters(const RenderStyle* oldStyle, const RenderStyle*
updateOrRemoveFilterEffectRenderer();
}
+void RenderLayer::updateClipPath(const RenderStyle* oldStyle, const RenderStyle* newStyle)
+{
+ if (!newStyle->clipPath() && (!oldStyle || !oldStyle->clipPath()))
+ return;
+
+ updateOrRemoveClipPathClients();
+}
+
+void RenderLayer::updateOrRemoveClipPathClients()
+{
+ if (!hasClipPath()) {
+ removeClipPathInfoIfNeeded();
+ return;
+ }
+
+ if (renderer()->style()->clipPath()->type() == ClipPathOperation::REFERENCE)
+ ensureClipPathInfo()->updateReferenceClipPathClients(renderer()->style()->clipPath());
+ else if (hasClipPathInfo())
+ clipPathInfo()->removeReferenceClipPathClients();
+}
+
bool RenderLayer::attemptDirectCompositingUpdate(StyleDifference diff, const RenderStyle* oldStyle)
{
CompositingReasons oldPotentialCompositingReasonsFromStyle = m_potentialCompositingReasonsFromStyle;
@@ -3634,6 +3657,7 @@ void RenderLayer::styleChanged(StyleDifference diff, const RenderStyle* oldStyle
updateTransform(oldStyle, renderer()->style());
updateFilters(oldStyle, renderer()->style());
+ updateClipPath(oldStyle, renderer()->style());
setNeedsCompositingInputsUpdate();
}

Powered by Google App Engine
This is Rietveld 408576698