LayoutTests/css3/clippath/clippath-animated.html - Issue 423823004: Add support for SVG Clip paths in HTML

Side by Side Diff: LayoutTests/css3/clippath/clippath-animated.html

Issue 423823004: Add support for SVG Clip paths in HTML (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed unwanted code from RenderLayerClipPathInfo.* and Renderlayer.cpp and Renamed filters to svg… Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	pdr. 2014/08/04 17:06:31 This test passes both with or without your patch. This test passes both with or without your patch. I didn't test the other tests manually but in most cases the tests should fail before your code changes and pass with it. Shanmuga Pandi 2014/08/05 11:30:35 Hello pdr, Thanks for your time and review. Thi Show quoted text On 2014/08/04 17:06:31, pdr wrote: > This test passes both with or without your patch. I didn't test the other tests > manually but in most cases the tests should fail before your code changes and > pass with it. Hello pdr, Thanks for your time and review. This layout test cases passes with and without my changes if I run "run-webkit-tests". But it is failed if I open clippath-animated.html in the browser window. You can still see some "red" portion with out this changes. Actually it should be full green. I have no clue why it is giving different results. Could you let me know , what I am doing wrong here? Shanmuga Pandi 2014/08/05 14:19:56 Will "run-webkit-tests" trigger any extra repaint Show quoted text On 2014/08/04 17:06:31, pdr wrote: > This test passes both with or without your patch. I didn't test the other tests > manually but in most cases the tests should fail before your code changes and > pass with it. Will "run-webkit-tests" trigger any extra repaint while capture screenshot? If yes, then actual issue will not be visible. Thats why this layout test cases passes with/without my patch.
	2 <head>

	3 <style>

	4 .error {

	5 width: 100px;

	6 height: 100px;

	7 background-color: red;

	8 position: absolute;

	9 }

	10 .clipped {

	11 width: 100px;

	12 height: 100px;

	13 background-color: green;

	14 -webkit-clip-path: url(#svgPath);

	15 clip-path: url(#svgPath);

	16 }

	17 </style>

	18 </head>

	19 <body>

	20 <script>

	21 if (window.testRunner)

	22 testRunner.waitUntilDone();

	23

	24 setTimeout(function() {

	25 if (window.testRunner)

	26 testRunner.notifyDone();

	27 }, 1000);
	pdr. 2014/08/04 17:06:31 This line is incorrectly indented. As I said in my This line is incorrectly indented. As I said in my first review, 1 second is far too long for a layouttest. Please use something under 100ms. Ideally, no explicit timeouts would be required but because these effects are both time based and driven off layout, sometimes they are required. You can try using [svg element].setCurrentTime() to drive the animations forward manually without waiting for them. Shanmuga Pandi 2014/08/05 14:19:56 Acknowledged. Show quoted text On 2014/08/04 17:06:31, pdr wrote: > This line is incorrectly indented. As I said in my first review, 1 second is far > too long for a layouttest. Please use something under 100ms. Ideally, no > explicit timeouts would be required but because these effects are both time > based and driven off layout, sometimes they are required. You can try using [svg > element].setCurrentTime() to drive the animations forward manually without > waiting for them. Acknowledged.
	28 </script>

	29 <div class="error"></div>

	30 <div class="clipped"></div>

	31 <svg height="0" width="0">

	32 <defs>

	33 <clipPath id="svgPath" clipPathUnits="objectBoundingBox">

	34 <circle cx="0.5" cy="0.5" r="0.5">

	35 <animate attributeName="r" attributeType="XML" from="0.5" to="1" begin=" 0.1s" dur="0.05s" fill="freeze"/>

	36 </circle>

	37 </clipPath>

	38 </defs>

	39 </svg>

	40 </body>

	41 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/css3/clippath/clippath-animated-expected.html » ('j') | LayoutTests/css3/clippath/clippath-animated-expected.html » ('J')