ManualTests/clip-path-animated.html - Issue 423823004: Add support for SVG Clip paths in HTML

Side by Side Diff: ManualTests/clip-path-animated.html

Issue 423823004: Add support for SVG Clip paths in HTML (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Try to correct A+ mode Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	pdr. 2014/07/28 16:23:52 Your test looks nicely written but we will need to Your test looks nicely written but we will need to create an automated test for this. Look in the LayoutTests/svg directory for examples that have animations. 1s is too long for a single test so you will need to make sure the new test finishes as quickly as possible. Stephen White 2014/07/29 15:12:26 +1 for using LayoutTests. You could look at css3/f Show quoted text On 2014/07/28 16:23:52, pdr wrote: > Your test looks nicely written but we will need to create an automated test for > this. Look in the LayoutTests/svg directory for examples that have animations. > 1s is too long for a single test so you will need to make sure the new test > finishes as quickly as possible. +1 for using LayoutTests. You could look at css3/filters/effect-reference* for examples of tests for similar functionality in CSS filters, such as effect-reference-add-hw.html, effect-reference-delete-crash.html, effect-reference-rename.html, etc. Try to use a text-only test (-expected.txt) or a reftest (-expected.html) where possible. You may also find the text-based repaint tests useful, e.g. effect-reference-repaint-: they use fast/repaint/resources/text-based-repaint.js to produce a list of repaint rects in text form. Shanmuga Pandi* 2014/08/01 05:20:39 Done. Show quoted text On 2014/07/28 16:23:52, pdr wrote: > Your test looks nicely written but we will need to create an automated test for > this. Look in the LayoutTests/svg directory for examples that have animations. > 1s is too long for a single test so you will need to make sure the new test > finishes as quickly as possible. Done. Shanmuga Pandi 2014/08/01 05:20:39 Done. Show quoted text On 2014/07/29 15:12:26, Stephen White wrote: > On 2014/07/28 16:23:52, pdr wrote: > > Your test looks nicely written but we will need to create an automated test > for > > this. Look in the LayoutTests/svg directory for examples that have animations. > > 1s is too long for a single test so you will need to make sure the new test > > finishes as quickly as possible. > > +1 for using LayoutTests. You could look at css3/filters/effect-reference* for > examples of tests for similar functionality in CSS filters, such as > effect-reference-add-hw.html, effect-reference-delete-crash.html, > effect-reference-rename.html, etc. Try to use a text-only test (-expected.txt) > or a reftest (-expected.html) where possible. > > You may also find the text-based repaint tests useful, e.g. > effect-reference-repaint-*: they use > fast/repaint/resources/text-based-repaint.js to produce a list of repaint rects > in text form. Done.
	2 <style>

	3 .error {

	4 width: 100px;

	5 height: 100px;

	6 background-color: red;

	7 position: absolute;

	8 }

	9 .clipped {

	10 width: 100px;

	11 height: 100px;

	12 background-color: green;

	13 -webkit-clip-path: url(#svgPath);

	14 clip-path: url(#svgPath);

	15 }

	16 </style>

	17 <div class="error"></div>

	18 <div class="clipped"></div>

	19 <p>After 1 second, there should be a green rectangle, and no red visible.</p>

	20 <svg height="0" width="0">

	21 <defs>

	22 <clipPath id="svgPath" clipPathUnits="objectBoundingBox">

	23 <circle cx="0.5" cy="0.5" r="0.5">

	24 <animate attributeName="r" attributeType="XML" from="0.25" to="1" begin= "0s" dur="1s" fill="freeze"/>

	25 </circle>

	26 </clipPath>

	27 </defs>

	28 </svg>

OLD	NEW

« no previous file with comments | « no previous file | ManualTests/clip-path-mutated.html » ('j') | ManualTests/clip-path-mutated.html » ('J')