Sdch view for net-internals

chrome/browser/ui/webui/net_internals/net_internals_ui.cc

Index: chrome/browser/ui/webui/net_internals/net_internals_ui.cc
diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
index e959c6b367077c716560167499489402c75a0530..0a698974a2b6b76a402d435a231c4d9bb49ee4d1 100644
--- a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
@@ -57,6 +57,7 @@
 #include "net/base/net_errors.h"
 #include "net/base/net_log_logger.h"
 #include "net/base/net_util.h"
+#include "net/base/sdch_manager.h"
 #include "net/disk_cache/disk_cache.h"
 #include "net/dns/host_cache.h"
 #include "net/dns/host_resolver.h"
@@ -404,6 +405,7 @@ class NetInternalsMessageHandler::IOThreadImpl
   void OnGetSpdyStatus(const base::ListValue* list);
   void OnGetSpdyAlternateProtocolMappings(const base::ListValue* list);
   void OnGetQuicInfo(const base::ListValue* list);
+  void OnGetSdchInfo(const base::ListValue* list);
 #if defined(OS_WIN)
   void OnGetServiceProviders(const base::ListValue* list);
 #endif
@@ -611,6 +613,10 @@ void NetInternalsMessageHandler::RegisterMessages() {
       "getQuicInfo",
       base::Bind(&IOThreadImpl::CallbackHelper,
                  &IOThreadImpl::OnGetQuicInfo, proxy_));
+  web_ui()->RegisterMessageCallback(
+      "getSdchInfo",
+      base::Bind(
+          &IOThreadImpl::CallbackHelper, &IOThreadImpl::OnGetSdchInfo, proxy_));

[mmenke, 2014/10/29 22:20:44]

Note:  I added a new file net/base/net_log_util with a single function to
retrieve a bunch of info, that takes as input a bunch of flags.  Should move
this stuff there.  Should be a fairly minor change, but have to modify the
Javascript browser_bridge code slightly, too.

Forgot it would affect this CL.

One trickiness is that when there's no sdch_manager, we'll still have to return
something, with the new ways things are done (base::Dictionary doesn't support
NULLs, I believe).



The motivation for that code is to allow creating full log dumps without
net-internals.

 #if defined(OS_WIN)
   web_ui()->RegisterMessageCallback(
       "getServiceProviders",
@@ -1352,6 +1358,16 @@ void NetInternalsMessageHandler::IOThreadImpl::OnGetQuicInfo(
   SendJavascriptCommand("receivedQuicInfo", quic_info);
 }
 
+void NetInternalsMessageHandler::IOThreadImpl::OnGetSdchInfo(
+    const base::ListValue* list) {
+  DCHECK(!list);
+  net::SdchManager* sdch_manager = GetMainContext()->sdch_manager();
+
+  base::Value* sdch_info =
+      sdch_manager ? sdch_manager->SdchInfoToValue() : NULL;
+  SendJavascriptCommand("receivedSdchInfo", sdch_info);
+}
+
 #if defined(OS_WIN)
 void NetInternalsMessageHandler::IOThreadImpl::OnGetServiceProviders(
     const base::ListValue* list) {