Sdch view for net-internals

net/base/net_error_list.h

Index: net/base/net_error_list.h
diff --git a/net/base/net_error_list.h b/net/base/net_error_list.h
index b805dd6ac7ecb01ddd4248bf412d78fb4973b123..f1555078fe09c0f8de03f94b596fd210677325ec 100644
--- a/net/base/net_error_list.h
+++ b/net/base/net_error_list.h
@@ -662,6 +662,9 @@ NET_ERROR(NO_PRIVATE_KEY_FOR_CERT, -502)
 // An error adding to the OS certificate database (e.g. OS X Keychain).
 NET_ERROR(ADD_USER_CERT_FAILED, -503)
 
+// Some problems with SDCH occur.
+NET_ERROR(SDCH_PROBLEM, -504)

[Randy Smith (Not in Mondays), 2014/09/18 20:55:51]

I don't think this is used anymore; remove?

[baranovich, 2014/09/19 12:42:44]

No, it is still used by net-internals code. I need some error code to signal ui
to paint URL_REQUEST red in event log.

[Randy Smith (Not in Mondays), 2014/09/29 21:21:57]

Ah, gotcha, that makes sense.

I could imagine you'll be unhappy with me for saying this :-{, but: I'd rather
not add a net error code for this purpose.  Would you be willing to write a
mapping function from SDCH problem codes to existing net error codes and call it
at the various points at which you call NetLog::AddEvent(*SDCH*ERROR, ...)?  
Something like content/browser/download/download_interrupt_reasons_impl.cc
(though that goes the other way).  It doesn't have to be a precisely correct
mapping; something that gestures in the right direction is sufficient.

Or it occurs to me, now that I've suggested the complicated and baroque
solution: Is there any reason you can't just use NET_ERROR_FAILED?

[baranovich, 2014/09/30 13:16:51]

Done. Using ERR_FAILED instead

+
 // *** Code -600 is reserved (was FTP_PASV_COMMAND_FAILED). ***
 
 // A generic error for failed FTP control connection command.