net/base/sdch_problem_codes.h - Issue 423813002: Sdch view for net-internals

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/base/sdch_problem_codes.h

Issue 423813002: Sdch view for net-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Declare SdchProblemCode Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef NET_BASE_SDCH_PROBLEM_CODES_H_

	6 #define NET_BASE_SDCH_PROBLEM_CODES_H_

	7

	8 namespace net {

	9

	10 // A list of errors that appeared and were either resolved, or used to turn

	11 // off sdch encoding.

	12 enum SdchProblemCode {

	13 SDCH_OK = 0,
	Randy Smith (Not in Mondays) 2014/10/28 22:16:27 Any reason for this not to be in sdch_problem_code Any reason for this not to be in sdch_problem_code_list.h? Not a big deal, but I lean towards keeping all values in the same conceptual namespace in the same place. baranovich 2014/10/29 18:28:43 Done. Show quoted text On 2014/10/28 22:16:27, rdsmith wrote: > Any reason for this not to be in sdch_problem_code_list.h? Not a big deal, but > I lean towards keeping all values in the same conceptual namespace in the same > place. Done.
	14

	15 #define SDCH_PROBLEM_CODE(label, value) SDCH_##label = value,

	16 #include "net/base/sdch_problem_code_list.h"

	17 #undef SDCH_PROBLEM_CODE

	18 };

	19

	20 } // namespace net

	21

	22 #endif // NET_BASE_SDCH_PROBLEM_CODES_H_

OLD	NEW