Sdch view for net-internals

net/base/sdch_dictionary_fetcher.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(rdsmith): This class needs to be moved out to the net/ embedder and
 // hooked into whatever mechanisms the embedder uses for authentication.
 // Specifically, this class needs methods overriding
 // URLRequest::Delegate::{OnAuthRequired,OnCertificateRequested} and can't
 // implement them at the net/ layer.
 
 #ifndef NET_BASE_SDCH_DICTIONARY_FETCHER_H_
 #define NET_BASE_SDCH_DICTIONARY_FETCHER_H_
 
 #include <queue>
 #include <set>
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/non_thread_safe.h"
+#include "net/base/net_log.h"

[Randy Smith (Not in Mondays), 2014/09/29 21:21:57]

Why is this needed in the header file?  It doesn't seem used.

[baranovich, 2014/09/30 13:16:51]

Done.

 #include "net/base/sdch_manager.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_request.h"
 
 namespace net {
 
 class URLRequest;
 class URLRequestThrottlerEntryInterface;
 
 // This class implements the SdchFetcher interface. It queues requests
 // for dictionaries and dispatches them serially, implementing
 // the URLRequest::Delegate interface to handle callbacks (but see above
 // TODO). It tracks all requests, only attempting to fetch each dictionary
 // once.
 class NET_EXPORT SdchDictionaryFetcher
     : public SdchFetcher,
       public URLRequest::Delegate,
       public base::NonThreadSafe {
  public:
   // The consumer must guarantee that |*consumer| and |*context| outlive
   // this object.
   SdchDictionaryFetcher(SdchFetcher::Delegate* consumer,
                         URLRequestContext* context);
   virtual ~SdchDictionaryFetcher();
 
   // Implementation of SdchFetcher methods.
-  virtual void Schedule(const GURL& dictionary_url) OVERRIDE;
+  virtual ScheduleResult Schedule(const GURL& dictionary_url) OVERRIDE;
   virtual void Cancel() OVERRIDE;
 
   // Implementation of URLRequest::Delegate methods.
   virtual void OnResponseStarted(URLRequest* request) OVERRIDE;
   virtual void OnReadCompleted(URLRequest* request, int bytes_read) OVERRIDE;
 
  private:
   enum State {
     STATE_NONE,
     STATE_IDLE,
@@ skipping 45 matching lines @@
   URLRequestContext* context_;
 
   base::WeakPtrFactory<SdchDictionaryFetcher> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(SdchDictionaryFetcher);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_SDCH_DICTIONARY_FETCHER_H_