Sdch view for net-internals

net/base/net_error_list.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file intentionally does not have header guards, it's included
 // inside a macro to generate enum values.
 
 // This file contains the list of network errors.
 
 //
@@ skipping 644 matching lines @@
 // The server's response was insecure (e.g. there was a cert error).
 NET_ERROR(INSECURE_RESPONSE, -501)
 
 // The server responded to a <keygen> with a generated client cert that we
 // don't have the matching private key for.
 NET_ERROR(NO_PRIVATE_KEY_FOR_CERT, -502)
 
 // An error adding to the OS certificate database (e.g. OS X Keychain).
 NET_ERROR(ADD_USER_CERT_FAILED, -503)
 
+// Some problems with SDCH occur.
+NET_ERROR(SDCH_PROBLEM, -504)

[Randy Smith (Not in Mondays), 2014/09/18 20:55:51]

I don't think this is used anymore; remove?

[baranovich, 2014/09/19 12:42:44]

No, it is still used by net-internals code. I need some error code to signal ui
to paint URL_REQUEST red in event log.

[Randy Smith (Not in Mondays), 2014/09/29 21:21:57]

Ah, gotcha, that makes sense.

I could imagine you'll be unhappy with me for saying this :-{, but: I'd rather
not add a net error code for this purpose.  Would you be willing to write a
mapping function from SDCH problem codes to existing net error codes and call it
at the various points at which you call NetLog::AddEvent(*SDCH*ERROR, ...)?  
Something like content/browser/download/download_interrupt_reasons_impl.cc
(though that goes the other way).  It doesn't have to be a precisely correct
mapping; something that gestures in the right direction is sufficient.

Or it occurs to me, now that I've suggested the complicated and baroque
solution: Is there any reason you can't just use NET_ERROR_FAILED?

[baranovich, 2014/09/30 13:16:51]

Done. Using ERR_FAILED instead

+
 // *** Code -600 is reserved (was FTP_PASV_COMMAND_FAILED). ***
 
 // A generic error for failed FTP control connection command.
 // If possible, please use or add a more specific error code.
 NET_ERROR(FTP_FAILED, -601)
 
 // The server cannot fulfill the request at this point. This is a temporary
 // error.
 // FTP response code 421.
 NET_ERROR(FTP_SERVICE_UNAVAILABLE, -602)
@@ skipping 90 matching lines @@
 NET_ERROR(DNS_TIMED_OUT, -803)
 
 // The entry was not found in cache, for cache-only lookups.
 NET_ERROR(DNS_CACHE_MISS, -804)
 
 // Suffix search list rules prevent resolution of the given host name.
 NET_ERROR(DNS_SEARCH_EMPTY, -805)
 
 // Failed to sort addresses according to RFC3484.
 NET_ERROR(DNS_SORT_ERROR, -806)