chrome/browser/resources/net_internals/sdch_view.html - Issue 423813002: Sdch view for net-internals

Side by Side Diff: chrome/browser/resources/net_internals/sdch_view.html

Issue 423813002: Sdch view for net-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adopt logging for URLReqest-based dict fetcher + cosmetics Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/net_internals/main.js ('K') | « chrome/browser/resources/net_internals/main.js ('k') | chrome/browser/resources/net_internals/sdch_view.js » ('j') | chrome/test/data/webui/net_internals/net_internals_test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <div id=sdch-view-tab-content class=content-box>

	2 <ul style='margin-top:0'>

	3 <li>SDCH Enabled: <span jscontent="!!sdch_enabled"></span></li>

	4 <li>Secure Scheme Support Enabled: <span jscontent="!!secure_scheme_support" ></span></li>

	5 </ul>

	6

	7 <p><a href="#events&q=type:URL_REQUEST%20is:error%20SDCH_RESOURCE">View SDCH r esource errors</a></p>

	8

	9 <p><a href="#events&q=type:URL_REQUEST%20is:error%20SDCH_DICTIONARY">View SDCH dictionary fetch errors</a></p>
	Randy Smith (Not in Mondays) 2014/09/29 21:21:56 These two links are effectively shortcuts for comm These two links are effectively shortcuts for common searches that people may want to do in the events tab. I like that (though Matt might shoot it down based on overall net-internals design) but if we're going to do that, I'd personally like a couple more: * All SDCH dictionary fetches. * All URL requests encoded with SDCH * All URL requests advertising SDCH dictionaries * (Stretching; not sure this is a good idea) All URL requests advertising SDCH dictionaries that did/did not have responses with SDCH encoding. Randy Smith (Not in Mondays) 2014/09/29 21:21:56 Suggestion: I think this section might look better Suggestion: I think this section might look better to the user if it was something like: SDCH Errors: _Resource_ <tab> _Dictionary_ With the links inactive and " (none)" appended to the names if there aren't any errors of that type (if that's possible). Randy Smith (Not in Mondays) 2014/09/29 21:21:56 I don't think this is in the style guide, so it sh I don't think this is in the style guide, so it should be taken as purely my preference and just a suggestion, but: I'd feel better if these lines were < 80 characters, and I don't think there's anything stopping that if they're nested. baranovich 2014/09/30 13:16:51 Done. Show quoted text On 2014/09/29 21:21:56, rdsmith wrote: > These two links are effectively shortcuts for common searches that people may > want to do in the events tab. I like that (though Matt might shoot it down > based on overall net-internals design) but if we're going to do that, I'd > personally like a couple more: > * All SDCH dictionary fetches. > * All URL requests encoded with SDCH > * All URL requests advertising SDCH dictionaries > * (Stretching; not sure this is a good idea) All URL requests advertising SDCH > dictionaries that did/did not have responses with SDCH encoding. Done. baranovich 2014/09/30 13:16:51 Done. Show quoted text On 2014/09/29 21:21:56, rdsmith wrote: > Suggestion: I think this section might look better to the user if it was > something like: > > SDCH Errors: _Resource_ <tab> _Dictionary_ > > With the links inactive and " (none)" appended to the names if there aren't any > errors of that type (if that's possible). Done. baranovich 2014/09/30 13:16:51 Done. I've figured out how to do only 2 of those a Show quoted text On 2014/09/29 21:21:56, rdsmith wrote: > These two links are effectively shortcuts for common searches that people may > want to do in the events tab. I like that (though Matt might shoot it down > based on overall net-internals design) but if we're going to do that, I'd > personally like a couple more: > * All SDCH dictionary fetches. > * All URL requests encoded with SDCH > * All URL requests advertising SDCH dictionaries > * (Stretching; not sure this is a good idea) All URL requests advertising SDCH > dictionaries that did/did not have responses with SDCH encoding. Done. I've figured out how to do only 2 of those although. "All URL requests encoded with SDCH" means filtering events by smth like/Content-Type\:.,\ssdch\s,./ which is not possible. Otherwise, that means adding special Event to filter by it. These requests are a subset of url requests advertising dictionaries. Minus small fractions of errors which can be found using "Decoding" error link. "(Stretching; not sure this is a good idea) All URL requests advertising SDCH dictionaries that did/did not have responses with SDCH encoding." also impossible with simple filtering. Effectively, this means a subset of requests with Decoding errors:) I'm not sure if such granularity is required.. imho the purpose of this tab to aid developers to debug their SDCH servers, which means that number of requests will be more or less limited and even if not, the developer probably will now the problem url and filter by it. But that's totally my intuition which may be absolutely wrong, plus wish to get this CL finally done as some MVP, and add more bells and whistles later:). Randy Smith (Not in Mondays) 2014/10/02 21:28:45 Is it reasonable to make the links inactive and ha Show quoted text On 2014/09/30 13:16:51, baranovich wrote: > On 2014/09/29 21:21:56, rdsmith wrote: > > Suggestion: I think this section might look better to the user if it was > > something like: > > > > SDCH Errors: _Resource_ <tab> _Dictionary_ > > > > With the links inactive and " (none)" appended to the names if there aren't > any > > errors of that type (if that's possible). > > Done. Is it reasonable to make the links inactive and have " (none)" appended if there aren't any of a particular type of error? That doesn't appear to be done in the current PS. (This may be a question for Matt.) Randy Smith (Not in Mondays) 2014/10/02 21:28:45 That's fine--I was brainstorming. Show quoted text On 2014/09/30 13:16:51, baranovich wrote: > On 2014/09/29 21:21:56, rdsmith wrote: > > These two links are effectively shortcuts for common searches that people may > > want to do in the events tab. I like that (though Matt might shoot it down > > based on overall net-internals design) but if we're going to do that, I'd > > personally like a couple more: > > * All SDCH dictionary fetches. > > * All URL requests encoded with SDCH > > * All URL requests advertising SDCH dictionaries > > * (Stretching; not sure this is a good idea) All URL requests advertising SDCH > > dictionaries that did/did not have responses with SDCH encoding. > > Done. I've figured out how to do only 2 of those although. That's fine--I was brainstorming. Show quoted text > "All URL requests encoded with SDCH" means filtering events by smth > like/Content-Type\:.,\ssdch\s,./ which is not possible. Otherwise, that > means adding special Event to filter by it. These requests are a subset of url > requests advertising dictionaries. Minus small fractions of errors which can be > found using "Decoding" error link. > > "(Stretching; not sure this is a good idea) All URL requests advertising SDCH > dictionaries that did/did not have responses with SDCH encoding." also > impossible with simple filtering. Effectively, this means a subset of requests > with Decoding errors:) > > I'm not sure if such granularity is required.. imho the purpose of this tab to > aid developers to debug their SDCH servers, which means that number of requests > will be more or less limited and even if not, the developer probably will now > the problem url and filter by it. But that's totally my intuition which may be > absolutely wrong, plus wish to get this CL finally done as some MVP, and add > more bells and whistles later:). We have different goals :-}; I want this tab to be usable for people (sic :-}; in practice this means me) debugging Chrome's implementation of SDCH. That's net-internals primary purpose (helping debug chrome problems). But I don't think there's any conflict between those goals. mmenke 2014/10/02 21:53:56 It's possible, but you'd have to search though all Show quoted text On 2014/10/02 21:28:45, rdsmith wrote: > On 2014/09/30 13:16:51, baranovich wrote: > > On 2014/09/29 21:21:56, rdsmith wrote: > > > Suggestion: I think this section might look better to the user if it was > > > something like: > > > > > > SDCH Errors: _Resource_ <tab> _Dictionary_ > > > > > > With the links inactive and " (none)" appended to the names if there aren't > > any > > > errors of that type (if that's possible). > > > > Done. > > Is it reasonable to make the links inactive and have " (none)" appended if there > aren't any of a particular type of error? That doesn't appear to be done in the > current PS. (This may be a question for Matt.) It's possible, but you'd have to search though all events for such an error as they occur. I'd recommend not trying to get too fancy on the first pass.
	10

	11 <h4>

	12 Dictionaries loaded: <span jscontent="dictionaries.length"></span>

	13 </h4>

	14 <table class="styled-table">

	15 <thead>

	16 <tr>

	17 <th>Domain</th>

	18 <th>Path</th>

	19 <th>Ports</th>

	20 <th>Server Hash</th>

	21 <th>Client Hash</th>

	22 <th>Url</th>

	23 </tr>

	24 </thead>

	25 <tbody>

	26 <tr jsselect="dictionaries">

	27 <td jscontent="domain"></td>

	28 <td jscontent="path"></td>

	29 <td jscontent="$this.ports ? $this.ports.join(', ') : ''"></td>

	30 <td jscontent="server_hash"></td>

	31 <td jscontent="client_hash"></td>

	32 <td jscontent="url"></td>

	33 </tr>

	34 </tbody>

	35 </table>

	36

	37 <h4>Blacklisted domains</h4>

	38 <table class="styled-table">

	39 <thead>

	40 <tr>

	41 <th>Domain</th>

	42 <th>Reason</th>

	43 <th>Tries to back off</th>

	44 </tr>

	45 </thead>

	46 <tbody>

	47 <tr jsselect="blacklisted">

	48 <td jscontent="domain"></td>

	49 <td jscontent="sdchProblemCodeToString(reason)"></td>

	50 <td jscontent="tries"></td>

	51 </tr>

	52 </tbody>

	53 </table>

	54 </div>

OLD	NEW