Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 423803002: Cosmetic change to base class lists. (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, tzik, fs, apavlov+blink_chromium.org, kouhei+svg_chromium.org, rwlbuis, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, krit, malch+blink_chromium.org, yurys+blink_chromium.org, aandrey+blink_chromium.org, falken, devtools-reviews_chromium.org, kinuko+serviceworker, pdr., loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, Stephen Chennney, alecflett+watch_chromium.org, michaeln, nhiroki, serviceworker-reviews, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), horo+watch_chromium.org, sergeyv+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Cosmetic change to base class lists. We have inconsistent style for multiple-line base class list. A) 37 instances class Foo : public BaseA , public BaseB , public BaseC { ... B) 17 instances class Foo : public BaseA, public BaseB, public BaseC { .... The number of A is larger than the number of B, and A is consistent with the initialization list style. This CL changes B to A. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -62 lines) Patch
M Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGLengthListTearOff.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGNumberListTearOff.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPathSegListTearOff.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGPointListTearOff.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGTransformListTearOff.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/screen_orientation/ScreenScreenOrientation.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerClient.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/CompositionUnderlineVectorBuilder.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/WebPagePopupImpl.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
Keishi, would you review this please?
6 years, 4 months ago (2014-07-28 10:08:14 UTC) #1
keishi
lgtm
6 years, 4 months ago (2014-07-28 10:10:07 UTC) #2
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 4 months ago (2014-07-28 10:12:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/423803002/1
6 years, 4 months ago (2014-07-28 10:13:18 UTC) #4
commit-bot: I haz the power
Change committed as 179018
6 years, 4 months ago (2014-07-28 10:16:23 UTC) #5
Peter Beverloo
6 years, 4 months ago (2014-07-28 10:34:52 UTC) #6
Message was sent while issue was closed.
On 2014/07/28 10:16:23, I haz the power (commit-bot) wrote:
> Change committed as 179018

Could we enforce this through the style checker?

Powered by Google App Engine
This is Rietveld 408576698