Issue 423793004: Missing explicit keyword in ctor of FooImpl.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 423793004: Missing explicit keyword in ctor of FooImpl.h (Closed)

Created:
6 years, 4 months ago by gyuyoung-inactive

Modified:
6 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, groby+blinkspell_chromium.org, kinuko+fileapi, nhiroki, philipj_slow, tzik

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Missing explicit keyword in ctor of FooImpl.h Need to add "explicit" to ctor which only has one argument in order to avoid implicit type conversion. Additionally some style nits are fixed together. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179226

Patch Set 1 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	Source/web/ContextMenuClientImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/DragClientImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/EditorClientImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/FrameLoaderClientImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/SpellCheckerClientImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/UserMediaClientImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebFileChooserCompletionImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebFontImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebPopupMenuImpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

gyuyoung-inactive

The CQ bit was checked by gyuyoung.kim@samsung.com

6 years, 4 months ago (2014-07-30 09:44:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/423793004/20001

6 years, 4 months ago (2014-07-30 09:45:04 UTC) #5

Message was sent while issue was closed.

Change committed as 179226

Expand Messages | Collapse Messages