Issue 423783002: WebAudio: Remove OfflineAudioDestinationNode::m_keepAliveWhileRendering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 423783002: WebAudio: Remove OfflineAudioDestinationNode::m_keepAliveWhileRendering (Closed)

Created:
6 years, 4 months ago by tkent

Modified:
6 years, 4 months ago

Reviewers:
oilpan-reviews, haraken, Raymond Toy

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

WebAudio: Remove OfflineAudioDestinationNode::m_keepAliveWhileRendering - Make sure |this| is kept while offlineRender() by passing PassRefPtr<> to bind(). - Make sure |this| is kept until finishing notifyComplete() by createCrossThreadTask(), which uses bind() internally. BUG=395941 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179008

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -25 lines)			Patch
	M	Source/modules/webaudio/OfflineAudioDestinationNode.h	View		2 chunks	+0 lines, -7 lines	1 comment	Download
	M	Source/modules/webaudio/OfflineAudioDestinationNode.cpp	View		3 chunks	+14 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tkent

Please take a look at this. https://codereview.chromium.org/423783002/diff/1/Source/modules/webaudio/OfflineAudioDestinationNode.h File Source/modules/webaudio/OfflineAudioDestinationNode.h (left): https://codereview.chromium.org/423783002/diff/1/Source/modules/webaudio/OfflineAudioDestinationNode.h#oldcode61 Source/modules/webaudio/OfflineAudioDestinationNode.h:61: class OfflineRenderingTask; This ...

6 years, 4 months ago (2014-07-28 06:35:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/423783002/1

6 years, 4 months ago (2014-07-28 08:08:32 UTC) #4

Message was sent while issue was closed.

Change committed as 179008

Expand Messages | Collapse Messages