Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: content/browser/compositor/delegated_frame_host.cc

Issue 423773002: Unified BeginFrame scheduling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/compositor/delegated_frame_host.cc
diff --git a/content/browser/compositor/delegated_frame_host.cc b/content/browser/compositor/delegated_frame_host.cc
index 5bc7efef46614792d9a0d02906ba5dfd881ed20b..280c1fcb9ce37744f111fbdb7d1bb9011b0809c1 100644
--- a/content/browser/compositor/delegated_frame_host.cc
+++ b/content/browser/compositor/delegated_frame_host.cc
@@ -6,6 +6,7 @@
#include "base/callback_helpers.h"
#include "base/command_line.h"
+#include "cc/output/begin_frame_args.h"
#include "cc/output/compositor_frame.h"
#include "cc/output/compositor_frame_ack.h"
#include "cc/output/copy_output_request.h"
@@ -759,6 +760,11 @@ void DelegatedFrameHost::CopyFromCompositingSurfaceHasResultForVideo(
finished_callback);
}
+void DelegatedFrameHost::UpdateVSyncParameters(const cc::BeginFrameArgs& args) {
+ vsync_timebase_ = args.frame_time;
+ vsync_interval_ = args.interval;
+}
+
////////////////////////////////////////////////////////////////////////////////
// DelegatedFrameHost, ui::CompositorObserver implementation:
@@ -803,16 +809,6 @@ void DelegatedFrameHost::OnCompositingLockStateChanged(
}
}
-void DelegatedFrameHost::OnUpdateVSyncParameters(
- base::TimeTicks timebase,
- base::TimeDelta interval) {
- vsync_timebase_ = timebase;
- vsync_interval_ = interval;
- RenderWidgetHostImpl* host = client_->GetHost();
- if (client_->IsVisible())
- host->UpdateVSyncParameters(timebase, interval);
-}
-
////////////////////////////////////////////////////////////////////////////////
// RenderWidgetHostViewAura, ImageTransportFactoryObserver implementation:
@@ -836,8 +832,6 @@ DelegatedFrameHost::~DelegatedFrameHost() {
surface_factory_->Destroy(surface_id_);
if (resource_collection_.get())
resource_collection_->SetClient(NULL);
-
- DCHECK(!vsync_manager_);
}
void DelegatedFrameHost::RunOnCommitCallbacks() {
@@ -862,12 +856,6 @@ void DelegatedFrameHost::AddOnCommitCallbackAndDisableLocks(
}
void DelegatedFrameHost::AddedToWindow() {
- ui::Compositor* compositor = client_->GetCompositor();
- if (compositor) {
- DCHECK(!vsync_manager_);
- vsync_manager_ = compositor->vsync_manager();
- vsync_manager_->AddObserver(this);
- }
}
void DelegatedFrameHost::RemovingFromWindow() {
@@ -877,11 +865,6 @@ void DelegatedFrameHost::RemovingFromWindow() {
ui::Compositor* compositor = client_->GetCompositor();
if (compositor && compositor->HasObserver(this))
compositor->RemoveObserver(this);
-
- if (vsync_manager_) {
- vsync_manager_->RemoveObserver(this);
- vsync_manager_ = NULL;
- }
}
void DelegatedFrameHost::LockResources() {

Powered by Google App Engine
This is Rietveld 408576698