Unified BeginFrame scheduling

cc/output/begin_frame_args.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_OUTPUT_BEGIN_FRAME_ARGS_H_
 #define CC_OUTPUT_BEGIN_FRAME_ARGS_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/time/time.h"
 #include "base/values.h"
@@ skipping 32 matching lines @@
   // send a BeginFrame that had been skipped. This only has an effect if the
   // deadline has passed, since the deadline is also used to trigger BeginFrame
   // retroactively.
   static base::TimeDelta DefaultRetroactiveBeginFramePeriod();
 
   bool IsValid() const { return interval >= base::TimeDelta(); }
 
   scoped_refptr<base::debug::ConvertableToTraceFormat> AsValue() const;
   void AsValueInto(base::debug::TracedValue* dict) const;
 
+  bool operator==(const BeginFrameArgs& other) const {

[mithro-old, 2014/09/09 03:22:37]

We have an operator== used just for testing in cc/test/begin_frame_args_test.h

Could you please remove that copy of the function?

It would probably be worth doing a minor refactoring the tests in
cc/output/begin_frame_args_unittest.cc to pull the equality tests out into their
own function.

+    return (frame_time == other.frame_time &

[brianderson, 2014/09/04 18:45:45]

& -> &&

+            deadline == other.deadline &&
+            interval == other.interval);
+  }
+
+  bool operator!=(const BeginFrameArgs& other) const {
+    return (frame_time != other.frame_time ||
+            deadline != other.deadline ||
+            interval != other.interval);
+  }
+
   base::TimeTicks frame_time;
   base::TimeTicks deadline;
   base::TimeDelta interval;
 
  private:
   BeginFrameArgs(base::TimeTicks frame_time,
                  base::TimeTicks deadline,
                  base::TimeDelta interval);
 };
 
 }  // namespace cc
 
 #endif  // CC_OUTPUT_BEGIN_FRAME_ARGS_H_