Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(56)

Issue 423753003: Pull in relevant targets when using xcode-ninja (Closed)

Created:
5 years, 1 month ago by Tobias
Modified:
4 years, 11 months ago
Reviewers:
sdefresne, justincohen
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@Fix-Xcode-ninja-workspace-3
Visibility:
Public.

Description

Pull in relevant targets when using xcode-ninja The tests gyptest-actions, gyptest-copies and gyptest-rules fail when using the xcode-ninja generator because xcode-ninja (by design) only creates targets for proper executables. In order for these three tests to pass, the targets they rely on need to be included explicitly. BUG=gyp:442 TEST=Run ./gyptest.py -f xcode-ninja test/generator-output/ Expected: all tests pass (instead of failing the three mentioned above). R=sdefresne@chromium.org, justincohen@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1961

Patch Set 1 #

Patch Set 2 : Rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M test/generator-output/gyptest-actions.py View 1 chunk +1 line, -0 lines 0 comments Download
M test/generator-output/gyptest-copies.py View 3 chunks +3 lines, -2 lines 0 comments Download
M test/generator-output/gyptest-rules.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
sdefresne
lgtm
5 years, 1 month ago (2014-07-30 12:10:37 UTC) #1
sdefresne
5 years, 1 month ago (2014-08-01 09:42:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r1961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698