Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 423703002: Fix bugs in sheriff-o-matic's pixel zoomer. (Closed)

Created:
6 years, 5 months ago by ojan
Modified:
6 years, 4 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Fix bugs in sheriff-o-matic's pixel zoomer. -x/y were swapped. Create a mock canvas context so we actually test this code path. -The zoomer was below the test list. z-index:1 to put it above. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -7 lines) Patch
A Tools/GardeningServer/base/ct-canvas-2d-context-mock.html View 1 chunk +37 lines, -0 lines 0 comments Download
M Tools/GardeningServer/ui/ct-results-comparison-zoomer.html View 2 chunks +10 lines, -7 lines 0 comments Download
M Tools/GardeningServer/ui/ct-results-comparison-zoomer-tests.html View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ojan
6 years, 5 months ago (2014-07-26 19:47:24 UTC) #1
leviw_travelin_and_unemployed
lgtm
6 years, 4 months ago (2014-07-28 23:15:23 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 4 months ago (2014-07-29 00:07:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/423703002/1
6 years, 4 months ago (2014-07-29 00:08:25 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 00:09:15 UTC) #5
Message was sent while issue was closed.
Change committed as 179073

Powered by Google App Engine
This is Rietveld 408576698