Issue 423673004: [DevTools] Switch from separate sendMessageToBackend method to using embedder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 423673004: [DevTools] Switch from separate sendMessageToBackend method to using embedder. (Closed)

Created:
6 years, 4 months ago by dgozman

Modified:
6 years, 3 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

[DevTools] Switch from separate sendMessageToBackend method to using embedder. We now use the same sendMessageToEmbedder dispatching channel, where one possible method is sendMessageToBrowser. BUG=398049

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -33 lines)			Patch
M	Source/core/inspector/InspectorFrontendClient.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorFrontendHost.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/inspector/InspectorFrontendHost.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/components/WorkerFrontendManager.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/host/InspectorFrontendHost.js	View	2 chunks	+2 lines, -14 lines	0 comments	Download
M	Source/devtools/front_end/sdk/InspectorBackend.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/WorkerManager.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/InspectorFrontendClientImpl.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/web/InspectorFrontendClientImpl.cpp	View	3 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dgozman

6 years, 3 months ago (2014-09-11 18:35:32 UTC) #4

On 2014/09/11 18:15:50, pfeldman wrote:
> Do we want to land this at this point?

I think, we will do this later and slightly modified. Closing for now.

Expand Messages | Collapse Messages