Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 423673003: [DevTools] Make sendMessageToBackend one of embedder messages. (Closed)

Created:
6 years, 4 months ago by dgozman
Modified:
6 years, 4 months ago
Reviewers:
Tom Sepez, pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Project:
chromium
Visibility:
Public.

Description

[DevTools] Make sendMessageToBackend one of embedder messages. The new message is called sendMessageToBrowser. BUG=398049 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287363

Patch Set 1 : #

Patch Set 2 : fixed compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M chrome/browser/devtools/devtools_embedder_message_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dgozman
Could you please take a look? tsepez - please review devtools_embedder_message_dispatcher. pfeldmand - please review ...
6 years, 4 months ago (2014-08-01 16:34:14 UTC) #1
Tom Sepez
What capability does this introduce that didn't exist before? I'm having a hard time inferring ...
6 years, 4 months ago (2014-08-01 16:44:03 UTC) #2
dgozman
On 2014/08/01 16:44:03, Tom Sepez wrote: > What capability does this introduce that didn't exist ...
6 years, 4 months ago (2014-08-01 16:53:58 UTC) #3
Tom Sepez
Ah, OK. LGTM
6 years, 4 months ago (2014-08-01 16:56:13 UTC) #4
pfeldman
lgtm
6 years, 4 months ago (2014-08-04 12:20:11 UTC) #5
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-04 12:48:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/423673003/20001
6 years, 4 months ago (2014-08-04 12:48:55 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-04 14:45:04 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 14:50:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg/builds/2824)
6 years, 4 months ago (2014-08-04 14:50:29 UTC) #10
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-04 15:27:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/423673003/40001
6 years, 4 months ago (2014-08-04 15:28:13 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 18:06:56 UTC) #13
Message was sent while issue was closed.
Change committed as 287363

Powered by Google App Engine
This is Rietveld 408576698