Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: Source/core/editing/RemoveFormatCommand.cpp

Issue 423673002: Use tighter typing in editing: EditingStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove isHTMLElement() check Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/editing/EditingStyle.cpp ('k') | Source/core/editing/markup.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Computer, Inc. All rights reserved.
3 * Copyright (C) 2010 Google Inc. All rights reserved. 3 * Copyright (C) 2010 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 80
81 void RemoveFormatCommand::doApply() 81 void RemoveFormatCommand::doApply()
82 { 82 {
83 LocalFrame* frame = document().frame(); 83 LocalFrame* frame = document().frame();
84 84
85 if (!frame->selection().selection().isNonOrphanedCaretOrRange()) 85 if (!frame->selection().selection().isNonOrphanedCaretOrRange())
86 return; 86 return;
87 87
88 // Get the default style for this editable root, it's the style that we'll g ive the 88 // Get the default style for this editable root, it's the style that we'll g ive the
89 // content that we're operating on. 89 // content that we're operating on.
90 Node* root = frame->selection().rootEditableElement(); 90 Element* root = frame->selection().rootEditableElement();
91 RefPtrWillBeRawPtr<EditingStyle> defaultStyle = EditingStyle::create(root); 91 RefPtrWillBeRawPtr<EditingStyle> defaultStyle = EditingStyle::create(root);
92 92
93 // We want to remove everything but transparent background. 93 // We want to remove everything but transparent background.
94 // FIXME: We shouldn't access style(). 94 // FIXME: We shouldn't access style().
95 defaultStyle->style()->setProperty(CSSPropertyBackgroundColor, CSSValueTrans parent); 95 defaultStyle->style()->setProperty(CSSPropertyBackgroundColor, CSSValueTrans parent);
96 96
97 applyCommandToComposite(ApplyStyleCommand::create(document(), defaultStyle.g et(), isElementForRemoveFormatCommand, editingAction())); 97 applyCommandToComposite(ApplyStyleCommand::create(document(), defaultStyle.g et(), isElementForRemoveFormatCommand, editingAction()));
98 } 98 }
99 99
100 } 100 }
OLDNEW
« no previous file with comments | « Source/core/editing/EditingStyle.cpp ('k') | Source/core/editing/markup.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698