Issue 42366: Fix single-process ui test failures from my previous change. The problem was...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42366: Fix single-process ui test failures from my previous change. The problem was... (Closed)

Created:
11 years, 9 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix single-process ui test failures from my previous change. The problem was that the wrong pid was being sent to RDH from RMF. It needs to be the fake pid for the in-process renderer. BUG=8890 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12040

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename pid() to GetProcessId #

Patch Set 3 : '' #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
M	chrome/browser/memory_details.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/resource_dispatcher_host.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc	View	1 2	4 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/task_manager_resource_providers.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/child_process_info.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

L G T M http://codereview.chromium.org/42366/diff/1/4 File chrome/common/child_process_info.h (right): http://codereview.chromium.org/42366/diff/1/4#newcode33 Line 33: virtual int pid() const ...

11 years, 9 months ago (2009-03-18 22:12:02 UTC) #2

jam

11 years, 9 months ago (2009-03-18 22:43:59 UTC) #3

http://codereview.chromium.org/42366/diff/1/4
File chrome/common/child_process_info.h (right):

http://codereview.chromium.org/42366/diff/1/4#newcode33
Line 33: virtual int pid() const {
On 2009/03/18 22:12:03, brettw wrote:
> Can you rename this to GetPid? Since it's virtual now, it's no longer as cheap
> as a variable, so shouldn't be named like one anymore.

Done.

Expand Messages | Collapse Messages