Issue 42363004: [Resource Timing] Memory cached resources should be reported on first use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42363004: [Resource Timing] Memory cached resources should be reported on first use. (Closed)

Created:
7 years, 2 months ago by James Simonsen

Modified:
7 years, 1 month ago

Reviewers:
tonyg, Nate Chapin

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

[Resource Timing] Memory cached resources should be reported on first use. BUG=230886 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160616

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -13 lines)			Patch
M	LayoutTests/http/tests/w3c/webperf/resources/generate_resource.php	View		1 chunk	+5 lines, -1 line	0 comments	Download
A	LayoutTests/http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_memory_cached.html	View		1 chunk	+76 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_memory_cached-expected.txt	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	Source/core/fetch/ResourceFetcher.cpp	View		3 chunks	+25 lines, -12 lines	0 comments	Download
M	Source/core/timing/ResourceTimingInfo.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Nate Chapin

LGTM, though I didn't really make sense of the boilerplate in the test.

7 years, 1 month ago (2013-10-25 16:31:03 UTC) #2

tonyg

On 2013/10/25 16:31:03, Nate Chapin wrote: > LGTM, though I didn't really make sense of ...

7 years, 1 month ago (2013-10-25 16:41:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonjam@chromium.org/42363004/70001

7 years, 1 month ago (2013-10-25 17:59:14 UTC) #4

Message was sent while issue was closed.

Change committed as 160616