Move strings from webkit/ to content/.

content/app/strings/content_strings.gyp

Index: content/app/strings/content_strings.gyp
diff --git a/content/app/strings/content_strings.gyp b/content/app/strings/content_strings.gyp
new file mode 100644
index 0000000000000000000000000000000000000000..0ee5d0666d2f8fedd8f9d9a71fee45f0a472080f
--- /dev/null
+++ b/content/app/strings/content_strings.gyp
@@ -0,0 +1,41 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'targets': [
+    {
+      # GN version: //content/app/strings
+      'target_name': 'content_strings',
+      'type': 'none',
+      'variables': {
+        'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/content/app/strings',
+      },
+      'actions': [
+        {
+          'action_name': 'generate_content_strings',
+          'variables': {
+            'grit_grd_file': 'content_strings.grd',
+          },
+          'includes': [ '../../../build/grit_action.gypi' ],
+        },
+        {
+          'action_name': 'rm_old_file',

[tfarina, 2014/08/03 14:16:57]

is it fine to have it here?

[jochen (gone - plz use gerrit), 2014/08/04 08:32:38]

i don't think we should have such magic in our gyp files.

Use a landmine for the bots and send a PSA.

[Nico, 2014/08/04 16:57:41]

How is a PSA better than things Just Working automatically?

(FWIW, I think the better way to make things Just Work is to make grit includes
fully qualified.)

[Ken Russell (switch to Gerrit), 2014/08/05 01:07:10]

I think whatever magic is needed to make this work automatically, without a
manual clobber build, should be included in this CL. Developers like myself
switch between multiple machines, and coming back to a machine a week later,
doing an update and nearly-clean build, and then finding that a clobber build
was needed after all is a waste of time. These gyp targets can be removed in a
few months once the changes have cycled through everyone's workspaces.

+          'inputs': [
+            '<(DEPTH)/build/whitespace_file.txt',  # Dummy input.
+          ],
+          'outputs': [
+            '<(INTERMEDIATE_DIR)/dummy_stamp',

[tfarina, 2014/08/03 14:16:57]

this is necessary, otherwise the ninja rule will build:

build :                 
    content_strings_target_rm_old_file_219febaf7ad770a6016bc4ac4c3e0d15 $       

    ../../build/whitespace_file.txt                                             


and when you run:

ninja -C out/Debug content_strings

ninja will complain with:
ninja: error: obj/content/app/strings/content_strings.ninja:224: expected path
build : content_strings_target_rm_old_file_219febaf7ad770a6016bc4ac4c3e0...
      ^ near here

[tfarina, 2014/08/03 14:17:32]

s/will build/will be

+          ],
+          'action': [
+            'python',
+            '-c',
+            'import os, sys; os.remove(sys.argv[1])',

[tfarina, 2014/08/03 14:30:12]

we also need os.path.exists(sys.argv[1]), otherwise in subsequent runs this will
try to remove a file that does not exist and will generate an error;

OSError: [Errno 2] No such file or directory:
'../../../out/Debug/gen/webkit/grit/webkit_strings.h'


But python didn't like the way I did:

FAILED: cd ../../content/app/strings; python -c "import os, sys; if
os.path.exists(sys.argv[1]): os.remove(sys.argv[1])"
../../../out/Debug/gen/webkit/grit/webkit_strings.h
  File "<string>", line 1
    import os, sys; if os.path.exists(sys.argv[1]): os.remove(sys.argv[1])
                     ^

Looks like I will have to put this in a separate py file?

+            '<(SHARED_INTERMEDIATE_DIR)/webkit/grit/webkit_strings.h'
+          ],
+        },
+      ],
+      'includes': [ '../../../build/grit_target.gypi' ],
+    },
+  ]
+}