Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 423613002: Mojo: split up service_provider.mojom (Closed)

Created:
6 years, 5 months ago by darin (slow to review)
Modified:
6 years, 4 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: split up service_provider.mojom Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286725

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix gn build #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -113 lines) Patch
M content/app/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/child/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/mojo/service_registry_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/render_frame_setup.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/content_app.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_common_mojo_bindings.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_gpu.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_plugin.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_ppapi_plugin.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_utility.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/utility/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/dbus/dbus_external_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/dbus/dbus_external_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/dbus_echo/dbus_echo_app.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/pepper_container_app/pepper_container_app.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/surfaces_app/surfaces_app.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/window_manager/debug_panel.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/mojo.gyp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/mojo_public.gypi View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/application_connection.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/application/application_impl.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/application/connect.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lazy_interface_ptr.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/service_connector.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/application/lib/service_registry.h View 1 chunk +2 lines, -1 line 0 comments Download
A + mojo/public/interfaces/application/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
A mojo/public/interfaces/application/application.mojom View 1 chunk +16 lines, -0 lines 0 comments Download
A mojo/public/interfaces/application/service_provider.mojom View 1 chunk +16 lines, -0 lines 0 comments Download
A mojo/public/interfaces/application/shell.mojom View 1 chunk +18 lines, -0 lines 0 comments Download
D mojo/public/interfaces/service_provider/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/public/interfaces/service_provider/service_provider.mojom View 1 chunk +0 lines, -32 lines 0 comments Download
M mojo/service_manager/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/service_manager/service_loader.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/service_manager/service_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/service_manager/service_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/service_manager/service_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/html_document_view.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/network/main.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_init_service_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_test_helper.h View 1 2 3 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
darin (slow to review)
6 years, 5 months ago (2014-07-26 00:15:55 UTC) #1
DaveMoore
lgtm
6 years, 4 months ago (2014-07-27 20:55:18 UTC) #2
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 4 months ago (2014-07-28 20:56:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/423613002/1
6 years, 4 months ago (2014-07-28 20:58:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-28 21:24:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 21:29:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/530) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/558) android_dbg ...
6 years, 4 months ago (2014-07-28 21:29:25 UTC) #7
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 4 months ago (2014-07-28 23:18:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/423613002/20001
6 years, 4 months ago (2014-07-28 23:19:20 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-29 02:55:57 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 03:01:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/638) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/675)
6 years, 4 months ago (2014-07-29 03:01:52 UTC) #12
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 4 months ago (2014-07-29 19:42:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/423613002/40001
6 years, 4 months ago (2014-07-29 19:43:21 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-29 22:55:21 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 23:00:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/1108)
6 years, 4 months ago (2014-07-29 23:00:12 UTC) #17
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 4 months ago (2014-07-31 00:04:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/423613002/60001
6 years, 4 months ago (2014-07-31 00:07:11 UTC) #19
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 08:58:48 UTC) #20
Message was sent while issue was closed. 
Change committed as 286725

Powered by Google App Engine
This is Rietveld 408576698