Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: mojo/system/dispatcher_unittest.cc

Issue 423583002: Convert WriteData...() to use the new user pointer handling (see r285350). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « mojo/system/dispatcher.cc ('k') | mojo/system/local_data_pipe.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/system/dispatcher.h" 5 #include "mojo/system/dispatcher.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/memory/scoped_vector.h" 9 #include "base/memory/scoped_vector.h"
10 #include "base/synchronization/waitable_event.h" 10 #include "base/synchronization/waitable_event.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 EXPECT_EQ(Dispatcher::kTypeUnknown, d->GetType()); 46 EXPECT_EQ(Dispatcher::kTypeUnknown, d->GetType());
47 47
48 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 48 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
49 d->WriteMessage(NullUserPointer(), 0, NULL, 49 d->WriteMessage(NullUserPointer(), 0, NULL,
50 MOJO_WRITE_MESSAGE_FLAG_NONE)); 50 MOJO_WRITE_MESSAGE_FLAG_NONE));
51 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 51 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
52 d->ReadMessage(NullUserPointer(), NullUserPointer(), NULL, NULL, 52 d->ReadMessage(NullUserPointer(), NullUserPointer(), NULL, NULL,
53 MOJO_WRITE_MESSAGE_FLAG_NONE)); 53 MOJO_WRITE_MESSAGE_FLAG_NONE));
54 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 54 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
55 d->WriteData(NULL, NULL, MOJO_WRITE_DATA_FLAG_NONE)); 55 d->WriteData(NullUserPointer(), NullUserPointer(),
56 MOJO_WRITE_DATA_FLAG_NONE));
56 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 57 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
57 d->BeginWriteData(NullUserPointer(), NullUserPointer(), 58 d->BeginWriteData(NullUserPointer(), NullUserPointer(),
58 MOJO_WRITE_DATA_FLAG_NONE)); 59 MOJO_WRITE_DATA_FLAG_NONE));
59 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 60 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
60 d->EndWriteData(0)); 61 d->EndWriteData(0));
61 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 62 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
62 d->ReadData(NullUserPointer(), NullUserPointer(), 63 d->ReadData(NullUserPointer(), NullUserPointer(),
63 MOJO_READ_DATA_FLAG_NONE)); 64 MOJO_READ_DATA_FLAG_NONE));
64 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 65 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
65 d->BeginReadData(NullUserPointer(), NullUserPointer(), 66 d->BeginReadData(NullUserPointer(), NullUserPointer(),
(...skipping 10 matching lines...) Expand all
76 77
77 EXPECT_EQ(MOJO_RESULT_OK, d->Close()); 78 EXPECT_EQ(MOJO_RESULT_OK, d->Close());
78 79
79 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 80 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
80 d->WriteMessage(NullUserPointer(), 0, NULL, 81 d->WriteMessage(NullUserPointer(), 0, NULL,
81 MOJO_WRITE_MESSAGE_FLAG_NONE)); 82 MOJO_WRITE_MESSAGE_FLAG_NONE));
82 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 83 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
83 d->ReadMessage(NullUserPointer(), NullUserPointer(), NULL, NULL, 84 d->ReadMessage(NullUserPointer(), NullUserPointer(), NULL, NULL,
84 MOJO_WRITE_MESSAGE_FLAG_NONE)); 85 MOJO_WRITE_MESSAGE_FLAG_NONE));
85 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 86 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
86 d->WriteData(NULL, NULL, MOJO_WRITE_DATA_FLAG_NONE)); 87 d->WriteData(NullUserPointer(), NullUserPointer(),
88 MOJO_WRITE_DATA_FLAG_NONE));
87 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 89 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
88 d->BeginWriteData(NullUserPointer(), NullUserPointer(), 90 d->BeginWriteData(NullUserPointer(), NullUserPointer(),
89 MOJO_WRITE_DATA_FLAG_NONE)); 91 MOJO_WRITE_DATA_FLAG_NONE));
90 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 92 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
91 d->EndWriteData(0)); 93 d->EndWriteData(0));
92 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 94 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
93 d->ReadData(NullUserPointer(), NullUserPointer(), 95 d->ReadData(NullUserPointer(), NullUserPointer(),
94 MOJO_READ_DATA_FLAG_NONE)); 96 MOJO_READ_DATA_FLAG_NONE));
95 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 97 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
96 d->BeginReadData(NullUserPointer(), NullUserPointer(), 98 d->BeginReadData(NullUserPointer(), NullUserPointer(),
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 MOJO_WRITE_MESSAGE_FLAG_NONE)); 157 MOJO_WRITE_MESSAGE_FLAG_NONE));
156 break; 158 break;
157 case READ_MESSAGE: 159 case READ_MESSAGE:
158 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 160 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
159 dispatcher_->ReadMessage(NullUserPointer(), NullUserPointer(), 161 dispatcher_->ReadMessage(NullUserPointer(), NullUserPointer(),
160 NULL, NULL, 162 NULL, NULL,
161 MOJO_WRITE_MESSAGE_FLAG_NONE)); 163 MOJO_WRITE_MESSAGE_FLAG_NONE));
162 break; 164 break;
163 case WRITE_DATA: 165 case WRITE_DATA:
164 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 166 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
165 dispatcher_->WriteData(NULL, NULL, 167 dispatcher_->WriteData(NullUserPointer(), NullUserPointer(),
166 MOJO_WRITE_DATA_FLAG_NONE)); 168 MOJO_WRITE_DATA_FLAG_NONE));
167 break; 169 break;
168 case BEGIN_WRITE_DATA: 170 case BEGIN_WRITE_DATA:
169 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 171 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
170 dispatcher_->BeginWriteData(NullUserPointer(), 172 dispatcher_->BeginWriteData(NullUserPointer(),
171 NullUserPointer(), 173 NullUserPointer(),
172 MOJO_WRITE_DATA_FLAG_NONE)); 174 MOJO_WRITE_DATA_FLAG_NONE));
173 break; 175 break;
174 case END_WRITE_DATA: 176 case END_WRITE_DATA:
175 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 177 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 event.Signal(); // Kicks off real work on the threads. 280 event.Signal(); // Kicks off real work on the threads.
279 } // Joins all the threads. 281 } // Joins all the threads.
280 282
281 EXPECT_EQ(MOJO_RESULT_OK, d->Close()); 283 EXPECT_EQ(MOJO_RESULT_OK, d->Close());
282 } 284 }
283 } 285 }
284 286
285 } // namespace 287 } // namespace
286 } // namespace system 288 } // namespace system
287 } // namespace mojo 289 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/system/dispatcher.cc ('k') | mojo/system/local_data_pipe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698