Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Issue 42356: Linux: fix crash when renderer asks for the location of a NULL window (Closed)

Created:
11 years, 9 months ago by agl
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: fix crash when renderer asks for the location of a NULL window There are cases where the renderer asks for the root rectangle of its window before we have a window for it. Since we still have the NativeViewId hack in place, this previously caused a crash.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/renderer_host/resource_message_filter.cc View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
agl
11 years, 9 months ago (2009-03-18 20:51:03 UTC) #1
Avi (use Gerrit)
http://codereview.chromium.org/42356/diff/1/2 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/42356/diff/1/2#newcode571 Line 571: *rect = gfx::Rect(0, 0, 0, 0); 1. The ...
11 years, 9 months ago (2009-03-18 21:09:32 UTC) #2
Craig Schlenter
11 years, 9 months ago (2009-03-19 05:05:50 UTC) #3
This bug is my fault :( I didn't anticipate being passed a null window. I did a
similar fix here:
http://codereview.chromium.org/42229/show
I wasn't sure if returning 0 would be acceptable since I hadn't dug into the
code in detail so I returned the root window rectangle.

Powered by Google App Engine
This is Rietveld 408576698