Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1621)

Unified Diff: Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py

Issue 423553004: Fix baselineoptimizer issue when deleting a virtual baseline not controlled by scm (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py
diff --git a/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py b/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py
index bc855865883791a770610b15a7f741cd1dec4bc4..7e6313809757f9166b09497a14e5b87ab896cc3d 100644
--- a/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py
+++ b/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py
@@ -100,8 +100,9 @@ class BaselineOptimizerTest(unittest.TestCase):
'/mock-checkout/third_party/WebKit/LayoutTests/platform/linux/another/test-expected.txt',
])
- def _assertOptimization(self, results_by_directory, expected_new_results_by_directory, baseline_dirname='', expected_files_to_delete=None):
- host = MockHost()
+ def _assertOptimization(self, results_by_directory, expected_new_results_by_directory, baseline_dirname='', expected_files_to_delete=None, host=None):
+ if not host:
+ host = MockHost()
fs = host.filesystem
webkit_base = WebKitFinder(fs).webkit_base()
baseline_name = 'mock-baseline-expected.txt'
@@ -253,6 +254,22 @@ class BaselineOptimizerTest(unittest.TestCase):
'/mock-checkout/third_party/WebKit/LayoutTests/platform/win/compositing/mock-baseline-expected.txt',
])
+ def test_virtual_root_redundant_with_ancestors_skip_scm_commands_with_file_not_in_scm(self):
+ self._assertOptimization({
+ 'virtual/softwarecompositing': '2',
+ 'platform/mac/compositing': '2',
+ 'platform/win/compositing': '2',
+ }, {
+ 'virtual/softwarecompositing': None,
+ 'compositing': '2',
+ },
+ baseline_dirname='virtual/softwarecompositing',
+ expected_files_to_delete=[
+ '/mock-checkout/third_party/WebKit/LayoutTests/platform/mac/compositing/mock-baseline-expected.txt',
+ '/mock-checkout/third_party/WebKit/LayoutTests/platform/win/compositing/mock-baseline-expected.txt',
+ ],
+ host=MockHost(scm=ExcludingMockSCM(['/mock-checkout/third_party/WebKit/LayoutTests/virtual/softwarecompositing/mock-baseline-expected.txt'])))
+
def test_virtual_root_not_redundant_with_ancestors(self):
self._assertOptimization({
'virtual/softwarecompositing': '2',
« no previous file with comments | « Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698