Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 423543002: Allow chrome.systemPrivate to be used by apps. (Closed)

Created:
6 years, 5 months ago by Tim Song
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Allow chrome.systemPrivate to be used by apps. BUG=367364 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/api/_permission_features.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Tim Song
6 years, 5 months ago (2014-07-25 18:10:54 UTC) #1
Tim Song
6 years, 5 months ago (2014-07-25 18:10:55 UTC) #2
asargent_no_longer_on_chrome
this lgtm, but +kalman in case he has any concerns
6 years, 5 months ago (2014-07-25 23:04:34 UTC) #3
not at google - send to devlin
lgtm
6 years, 5 months ago (2014-07-25 23:05:46 UTC) #4
Tim Song
The CQ bit was checked by tengs@chromium.org
6 years, 5 months ago (2014-07-26 01:08:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/423543002/1
6 years, 5 months ago (2014-07-26 05:00:31 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-26 20:02:40 UTC) #7
Message was sent while issue was closed. 
Change committed as 285799

Powered by Google App Engine
This is Rietveld 408576698