Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/browser/resources/options/alert_overlay.js

Issue 423533003: Use PageManager in About page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix settings app browser test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/help/help_page.js ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/alert_overlay.js
diff --git a/chrome/browser/resources/options/alert_overlay.js b/chrome/browser/resources/options/alert_overlay.js
index 09b95bf7db87915dd65e822107702c7e275c696d..cd7aaf36a093207d6206c41a33652162cd8f892d 100644
--- a/chrome/browser/resources/options/alert_overlay.js
+++ b/chrome/browser/resources/options/alert_overlay.js
@@ -9,14 +9,11 @@ cr.define('options', function() {
/**
* AlertOverlay class
* Encapsulated handling of a generic alert.
- * @class
+ * @constructor
+ * @extends {cr.ui.pageManager.Page}
*/
function AlertOverlay() {
Page.call(this, 'alertOverlay', '', 'alertOverlay');
- // AlertOverlay is special in that it is not tied to one page or overlay.
- // Set the nesting level arbitrarily high so as to always be recognized as
- // the top-most visible page.
- this.nestingLevelOverride = 99;
}
cr.addSingletonGetter(AlertOverlay);
@@ -36,6 +33,9 @@ cr.define('options', function() {
initializePage: function() {
Page.prototype.initializePage.call(this);
+ // AlertOverlay is special in that it is not tied to one page or overlay.
+ this.alwaysOnTop = true;
+
var self = this;
$('alertOverlayOk').onclick = function(event) {
self.handleOK_();
« no previous file with comments | « chrome/browser/resources/help/help_page.js ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698